Issue 7065012: Restore the gpu blacklist logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065012: Restore the gpu blacklist logic. (Closed)

Created:
9 years, 7 months ago by Zhenyao Mo

Modified:
9 years, 7 months ago

Reviewers:
nduca

CC:
chromium-reviews, jam, Jói, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Restore the gpu blacklist logic. The gpu blacklist is no longer applied due to a regression. I decided not to put this fix together with the rest of gpu blacklist logic regression recovering as this is more urgent and simple to fix. BUG=83639 TEST=gpu blacklist is applied. if a gpu feature should be blacklisted, it will. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86370

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/browser/gpu/gpu_data_manager.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nduca

9 years, 7 months ago (2011-05-24 00:06:11 UTC) #2

LGTM.

/me wonders if we should rename the DetermineBlahBlah function to make it
clearer that it has the side effects of making the blacklist work. Definitely
not something that should block this CL, of course.

Expand Messages | Collapse Messages