Add initialization callback support for Video Decoder PPAPI.

ppapi/c/dev/ppb_video_decoder_dev.h

Index: ppapi/c/dev/ppb_video_decoder_dev.h
diff --git a/ppapi/c/dev/ppb_video_decoder_dev.h b/ppapi/c/dev/ppb_video_decoder_dev.h
index 8cf98513232ff45328447aed8c920ff446ab66aa..46eded5b4b807f79cd69e5be166c41c7a302e9d9 100644
--- a/ppapi/c/dev/ppb_video_decoder_dev.h
+++ b/ppapi/c/dev/ppb_video_decoder_dev.h
@@ -9,8 +9,8 @@
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_var.h"
 
-#define PPB_VIDEODECODER_DEV_INTERFACE_0_7 "PPB_VideoDecoder(Dev);0.7"
-#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_7
+#define PPB_VIDEODECODER_DEV_INTERFACE_0_8 "PPB_VideoDecoder(Dev);0.8"
+#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_8
 
 // Video decoder interface.
 //
@@ -131,10 +131,12 @@ struct PPB_VideoDecoder_Dev {
   // Parameters:
   //   |instance| pointer to the plugin instance.
   //   |dec_config| the configuration which to use to initialize the decoder.
+  //   |callback| called after initialize is complete.
   //
   // The created decoder is returned as PP_Resource. NULL means failure.
   PP_Resource (*Create)(PP_Instance instance,

[darin (slow to review), 2011/05/31 21:40:47]

This method is misusing PP_CompletionCallback.  Any function that takes a
PP_CompletionCallback MUST return int32_t, and it must return
PP_OK_COMPLETIONPENDING when it will complete its work asynchronously or PP_OK /
some error code if the completion callback will not run.

In this case, it means that you need to break out a separate "init" method, just
like PPB_URLLoader::Open.

It looks like you already have an Init method under the hood, so this change
should be trivial.

-                        PP_VideoConfigElement* dec_config);
+                        PP_VideoConfigElement* dec_config,
+                        struct PP_CompletionCallback callback);
 
   // Tests whether |resource| is a video decoder created through Create
   // function of this interface.