Removed loginChallengeCalback for Me2Mom.

remoting/webapp/me2mom/remoting_session.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Maximum numer of lines to record in the debug log.
 // Only the most recent <n> lines are displayed.
 var MAX_DEBUG_LOG_SIZE = 1000;
 var remoting = chrome.extension.getBackgroundPage().remoting;
 
 // Message id so that we can identify (and ignore) message fade operations for
@@ skipping 95 matching lines @@
                   remoting.httpXmppProxy);
     return;
   }
 
   // Setup the callback that the plugin will call when the connection status
   // has changes and the UI needs to be updated. It needs to be an object with
   // a 'callback' property that contains the callback function.
   plugin.connectionInfoUpdate = connectionInfoUpdateCallback;
   plugin.debugInfo = debugInfoCallback;
   plugin.desktopSizeUpdate = desktopSizeChanged;
-  plugin.loginChallenge = loginChallengeCallback;

[Wez, 2011/05/23 21:14:54]

The code path that makes the loginChallenge callback doesn't check whether it's
set, I don't think, so instead of printing out a slightly misleading message
from JavaScript, we'll print out "Exception when invoking JS callback", which
seems worse.

[Jamie, 2011/05/23 22:24:58]

Done.

 
   addToDebugLog('Connect as user ' + remoting.username);
 
   // TODO(garykac): Clean exit if |connect| isn't a function.
   if (typeof plugin.connect === 'function') {
     if (remoting.connectMethod == 'sandboxed') {
       registerConnection();
     } else {
       plugin.connect(remoting.username, remoting.hostjid,
                      remoting.xmppAuthToken, remoting.accessCode);
@@ skipping 19 matching lines @@
 }
 
 function toggleScaleToFit() {
   remoting.scaleToFit = !remoting.scaleToFit;
   document.getElementById('scale_to_fit_toggle').value =
       remoting.scaleToFit ? 'No scaling' : 'Scale to fit';
   remoting.plugin.setScaleToFit(remoting.scaleToFit);
 }
 
 /**
- * This is the callback method that the plugin calls to request username and
- * password for logging into the remote host. For Me2Mom we are pre-authorized
- * so this should never be called.
- */
-function loginChallengeCallback() {
-  console.log("loginChallengeCallback called unexpectedly!");

[Wez, 2011/05/23 21:14:54]

Just take out the console.log() for now?

[Jamie, 2011/05/23 22:24:58]

Done.

-}
-
-/**
  * This is a callback that gets called when the desktop size contained in the
  * the plugin has changed.
  */
 function desktopSizeChanged() {
   var width = remoting.plugin.desktopWidth;
   var height = remoting.plugin.desktopHeight;
 
   addToDebugLog('desktop size changed: ' + width + 'x' + height);
   remoting.plugin.style.width = width + 'px';
   remoting.plugin.style.height = height + 'px';
@@ skipping 135 matching lines @@
   setClientStateMessage(
       'Video stats: bandwidth: ' + videoBandwidth.toFixed(2) + 'Kbps' +
       ', Latency: capture: ' + videoCaptureLatency.toFixed(2) + 'ms' +
       ', encode: ' + videoEncodeLatency.toFixed(2) + 'ms' +
       ', decode: ' + videoDecodeLatency.toFixed(2) + 'ms' +
       ', render: ' + videoRenderLatency.toFixed(2) + 'ms');
 
   // Update the stats once per second.
   window.setTimeout('updateStatusBarStats()', 1000);
 }