Removed loginChallengeCalback for Me2Mom.

Removed loginChallengeCalback for Me2Mom.

BUG=None
TEST=Check that Me2Mom still works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86355

[Jamie, 2011-05-23 21:04:21]

This CL removes the annoying "loginChallengeCallback called unexpectedly!"
message, which stemmed from a misunderstanding about where that callback
originates.

[Wez, 2011-05-23 21:14:54]

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
File remoting/webapp/me2mom/remoting_session.js (left):

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting_session.js:116: plugin.loginChallenge =
loginChallengeCallback;
The code path that makes the loginChallenge callback doesn't check whether it's
set, I don't think, so instead of printing out a slightly misleading message
from JavaScript, we'll print out "Exception when invoking JS callback", which
seems worse.

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting_session.js:161:
console.log("loginChallengeCallback called unexpectedly!");
Just take out the console.log() for now?

[Jamie, 2011-05-23 22:24:58]

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
File remoting/webapp/me2mom/remoting_session.js (left):

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting_session.js:116: plugin.loginChallenge =
loginChallengeCallback;
On 2011/05/23 21:14:54, Wez wrote:
> The code path that makes the loginChallenge callback doesn't check whether
it's
> set, I don't think, so instead of printing out a slightly misleading message
> from JavaScript, we'll print out "Exception when invoking JS callback", which
> seems worse.

Done.

http://codereview.chromium.org/7065009/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting_session.js:161:
console.log("loginChallengeCallback called unexpectedly!");
On 2011/05/23 21:14:54, Wez wrote:
> Just take out the console.log() for now?

Done.

[Wez, 2011-05-23 22:27:10]

LGTM