Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 7064054: make: Reapply r928 and r918. (Closed)

Created:
9 years, 6 months ago by Evan Martin
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: Reapply r928 and r918. shared_library and loadable_module behavior diverge: - loadable_module only exposes API that is explicitly exposed in the outermost gyp target (i.e. sources in the target itself). (This is not a change in behavior.) - shared_library exposes any API of any library is included in the output. E.g. a shared_library that composes three smaller libraries together will have the union of their API. (This is new.) Link lines now only contain the gyp depedencies for a given link. (We used to manually attempt to fix lines that were missing chains of shared library dependencies.) Committed: http://code.google.com/p/gyp/source/detail?r=934

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : simplified #

Patch Set 4 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M pylib/gyp/generator/make.py View 1 2 3 5 chunks +31 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
I again cannot produce any problems with this code locally, so I'm going to use ...
9 years, 6 months ago (2011-06-07 19:58:38 UTC) #1
Evan Martin
9 years, 6 months ago (2011-06-07 20:10:19 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698