Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 7064052: Revert 88142 to fix sync_integration_tests offline. (Closed)

Created:
9 years, 6 months ago by msw
Modified:
9 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, Avi (use Gerrit), estade+watch_chromium.org, jam, Erik does not do reviews, Paweł Hajdan Jr., kkania, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 88142 to fix sync_integration_tests offline. *Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL. *Update AboutSource to use the source_name of each about/chrome page. *Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/ -Redirect memory to memory-redirect (wasn't handling chrome://memory/). -Catalog all kChromeUI*Hosts in url_constants.cc -Simplify paths (credits, os-credits, ipc, settings, about/version). -Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison). -Favor GURL::SchemeIs and url_constants, update & expand tests. -Add and fixup chrome://chrome-urls (the about:about page). BUG=55771 TEST=Access about:, about://, chrome:, chrome:// pages. Review URL: http://codereview.chromium.org/7068007 TBR=msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -558 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 12 chunks +277 lines, -183 lines 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 2 chunks +39 lines, -41 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 5 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 5 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 3 chunks +4 lines, -49 lines 0 comments Download
M chrome/browser/net/view_blob_internals_job_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/view_http_cache_job_factory.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/BidiCheckerWebUITest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/about_page_handler.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/about_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/about_handler.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/url_constants.h View 6 chunks +34 lines, -65 lines 0 comments Download
M chrome/common/url_constants.cc View 5 chunks +30 lines, -65 lines 0 comments Download
M chrome/renderer/about_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M content/browser/site_instance.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
9 years, 6 months ago (2011-06-07 19:01:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698