Issue 7064045: Fix up clang on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064045: Fix up clang on mac. (Closed)

Created:
9 years, 7 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
mrossetti

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix up clang on mac. Clang didn't like my property decls. Cleaned it up a bit at the same time. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86520

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed up nit #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -11 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mrossetti

9 years, 7 months ago (2011-05-24 23:17:14 UTC) #2

lgtm

http://codereview.chromium.org/7064045/diff/1/chrome/browser/ui/cocoa/bookmar...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm
(right):

http://codereview.chromium.org/7064045/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm:27:
@implementation BookmarkBarFolderView(TestingAPI)
Should this be 'TestingOrInternalAPI'?

Expand Messages | Collapse Messages