Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 7064043: Update effecitve-TLD data files using the latest data from Mozilla. (Closed)

Created:
9 years, 7 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
wtc, Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Update effecitve-TLD data files using the latest data from Mozilla. 1) Downloaded http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_names.dat?raw=1 2) Removed whitespace from the ends of the lines 3) Added the Chromium note back in 4) Follow the instruction in net/tools/tld_cleanup/README to generate gperf and cc files. This data file comes from their changeset 70019:1de81dad52af from 2011-05-23 21:24 +0100 ( http://hg.mozilla.org/mozilla-central/rev/1de81dad52af ) BUG=37436 TEST=Type '도메인.한국' in the omnibox and see if we navigate to the site instead of triggering a search. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86531

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -10 lines) Patch
M net/base/effective_tld_names.dat View 1 2 3 16 chunks +121 lines, -7 lines 1 comment Download
M net/base/effective_tld_names.gperf View 1 2 3 37 chunks +57 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
Somehow, the patch for effective_tld_names.cc is very large (~24700 lines) and gcl refuses to upload ...
9 years, 7 months ago (2011-05-24 23:12:56 UTC) #1
Peter Kasting
LGTM if you fix the issue below http://codereview.chromium.org/7064043/diff/4003/net/base/effective_tld_names.dat File net/base/effective_tld_names.dat (right): http://codereview.chromium.org/7064043/diff/4003/net/base/effective_tld_names.dat#newcode387 net/base/effective_tld_names.dat:387: 9.bg This ...
9 years, 7 months ago (2011-05-24 23:36:30 UTC) #2
jungshik at Google
Thank you for catching it. I removed spurious tabs. Asking wtc (an owner) to approve ...
9 years, 7 months ago (2011-05-25 00:04:54 UTC) #3
wtc
9 years, 7 months ago (2011-05-25 00:14:28 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698