Issue 7064037: CrOS - Fix crash in file browser the second time you save a file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064037: CrOS - Fix crash in file browser the second time you save a file (Closed)

Created:
9 years, 7 months ago by James Cook

Modified:
9 years, 7 months ago

Reviewers:
achuithb

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

CrOS - Fix crash in file browser the second time you save a file We were not cleaning up callbacks after the dialog closed, so it crashed with a stale "params" pointer (user data for the callback). BUG=chromium-os:15650 TEST=Right-click Save As an image. Right-click Save As the same image again. Verify Chrome does not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86466

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/views/file_manager_dialogs.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Achuith, can you take a look? I forgot to clean up the callback object in ...

9 years, 7 months ago (2011-05-24 18:16:39 UTC) #1

LGTM

Expand Messages | Collapse Messages