content/browser/geolocation/geolocation_provider.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/geolocation_provider.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/geolocation/geolocation_provider.h

diff --git a/content/browser/geolocation/geolocation_provider.h b/content/browser/geolocation/geolocation_provider.h

index aaf398ed5ef8b69e22c8c63bb29661f0fcd33c8f..c955a3caf8e0caf2518647cf52e5a647ee2a8f40 100644

--- a/content/browser/geolocation/geolocation_provider.h

+++ b/content/browser/geolocation/geolocation_provider.h

@@ -57,7 +57,7 @@ class GeolocationProvider : public base::Thread, public GeolocationObserver {

private:

friend struct DefaultSingletonTraits<GeolocationProvider>;

- ~GeolocationProvider();

+ virtual ~GeolocationProvider();

bool OnClientThread() const;

bool OnGeolocationThread() const;