Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: content/plugin/npobject_stub.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/plugin/npobject_proxy.h ('k') | content/plugin/plugin_thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A class that receives IPC messages from an NPObjectProxy and calls the real 5 // A class that receives IPC messages from an NPObjectProxy and calls the real
6 // NPObject. 6 // NPObject.
7 7
8 #ifndef CONTENT_PLUGIN_NPOBJECT_STUB_H_ 8 #ifndef CONTENT_PLUGIN_NPOBJECT_STUB_H_
9 #define CONTENT_PLUGIN_NPOBJECT_STUB_H_ 9 #define CONTENT_PLUGIN_NPOBJECT_STUB_H_
10 #pragma once 10 #pragma once
(...skipping 18 matching lines...) Expand all
29 class NPObjectStub : public IPC::Channel::Listener, 29 class NPObjectStub : public IPC::Channel::Listener,
30 public IPC::Message::Sender, 30 public IPC::Message::Sender,
31 public base::SupportsWeakPtr<NPObjectStub>, 31 public base::SupportsWeakPtr<NPObjectStub>,
32 public NPObjectBase { 32 public NPObjectBase {
33 public: 33 public:
34 NPObjectStub(NPObject* npobject, 34 NPObjectStub(NPObject* npobject,
35 PluginChannelBase* channel, 35 PluginChannelBase* channel,
36 int route_id, 36 int route_id,
37 gfx::NativeViewId containing_window, 37 gfx::NativeViewId containing_window,
38 const GURL& page_url); 38 const GURL& page_url);
39 ~NPObjectStub(); 39 virtual ~NPObjectStub();
40 40
41 // IPC::Message::Sender implementation: 41 // IPC::Message::Sender implementation:
42 virtual bool Send(IPC::Message* msg); 42 virtual bool Send(IPC::Message* msg);
43 43
44 // Called when the plugin widget that this NPObject came from is destroyed. 44 // Called when the plugin widget that this NPObject came from is destroyed.
45 // This is needed because the renderer calls NPN_DeallocateObject on the 45 // This is needed because the renderer calls NPN_DeallocateObject on the
46 // window script object on destruction to avoid leaks. 46 // window script object on destruction to avoid leaks.
47 void OnPluginDestroyed(); 47 void OnPluginDestroyed();
48 48
49 // NPObjectBase implementation. 49 // NPObjectBase implementation.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 NPObject* npobject_; 86 NPObject* npobject_;
87 scoped_refptr<PluginChannelBase> channel_; 87 scoped_refptr<PluginChannelBase> channel_;
88 int route_id_; 88 int route_id_;
89 gfx::NativeViewId containing_window_; 89 gfx::NativeViewId containing_window_;
90 90
91 // The url of the main frame hosting the plugin. 91 // The url of the main frame hosting the plugin.
92 GURL page_url_; 92 GURL page_url_;
93 }; 93 };
94 94
95 #endif // CONTENT_PLUGIN_NPOBJECT_STUB_H_ 95 #endif // CONTENT_PLUGIN_NPOBJECT_STUB_H_
OLDNEW
« no previous file with comments | « content/plugin/npobject_proxy.h ('k') | content/plugin/plugin_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698