Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/ui/cocoa/download/download_item_mac.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_
6 #define CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_ 6 #define CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_
7 #pragma once 7 #pragma once
8 8
9 #import <Cocoa/Cocoa.h> 9 #import <Cocoa/Cocoa.h>
10 10
(...skipping 15 matching lines...) Expand all
26 // model. The owning object (DownloadItemController) must explicitly call 26 // model. The owning object (DownloadItemController) must explicitly call
27 // |LoadIcon| if it wants to display the icon associated with this download. 27 // |LoadIcon| if it wants to display the icon associated with this download.
28 28
29 class DownloadItemMac : DownloadItem::Observer { 29 class DownloadItemMac : DownloadItem::Observer {
30 public: 30 public:
31 // DownloadItemMac takes ownership of |download_model|. 31 // DownloadItemMac takes ownership of |download_model|.
32 DownloadItemMac(BaseDownloadItemModel* download_model, 32 DownloadItemMac(BaseDownloadItemModel* download_model,
33 DownloadItemController* controller); 33 DownloadItemController* controller);
34 34
35 // Destructor. 35 // Destructor.
36 ~DownloadItemMac(); 36 virtual ~DownloadItemMac();
37 37
38 // DownloadItem::Observer implementation 38 // DownloadItem::Observer implementation
39 virtual void OnDownloadUpdated(DownloadItem* download); 39 virtual void OnDownloadUpdated(DownloadItem* download);
40 virtual void OnDownloadOpened(DownloadItem* download); 40 virtual void OnDownloadOpened(DownloadItem* download);
41 41
42 BaseDownloadItemModel* download_model() { return download_model_.get(); } 42 BaseDownloadItemModel* download_model() { return download_model_.get(); }
43 43
44 // Asynchronous icon loading support. 44 // Asynchronous icon loading support.
45 void LoadIcon(); 45 void LoadIcon();
46 46
(...skipping 11 matching lines...) Expand all
58 // For canceling an in progress icon request. 58 // For canceling an in progress icon request.
59 CancelableRequestConsumerT<int, 0> icon_consumer_; 59 CancelableRequestConsumerT<int, 0> icon_consumer_;
60 60
61 // Stores the last known path where the file will be saved. 61 // Stores the last known path where the file will be saved.
62 FilePath lastFilePath_; 62 FilePath lastFilePath_;
63 63
64 DISALLOW_COPY_AND_ASSIGN(DownloadItemMac); 64 DISALLOW_COPY_AND_ASSIGN(DownloadItemMac);
65 }; 65 };
66 66
67 #endif // CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_ 67 #endif // CHROME_BROWSER_UI_COCOA_DOWNLOAD_DOWNLOAD_ITEM_MAC_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window_mac.h ('k') | chrome/browser/ui/cocoa/notifications/balloon_view_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698