Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: chrome/browser/extensions/extensions_ui.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 ExtensionsUIHTMLSource(); 47 ExtensionsUIHTMLSource();
48 48
49 // Called when the network layer has requested a resource underneath 49 // Called when the network layer has requested a resource underneath
50 // the path we registered. 50 // the path we registered.
51 virtual void StartDataRequest(const std::string& path, 51 virtual void StartDataRequest(const std::string& path,
52 bool is_incognito, 52 bool is_incognito,
53 int request_id); 53 int request_id);
54 virtual std::string GetMimeType(const std::string&) const; 54 virtual std::string GetMimeType(const std::string&) const;
55 55
56 private: 56 private:
57 ~ExtensionsUIHTMLSource() {} 57 virtual ~ExtensionsUIHTMLSource() {}
58 58
59 DISALLOW_COPY_AND_ASSIGN(ExtensionsUIHTMLSource); 59 DISALLOW_COPY_AND_ASSIGN(ExtensionsUIHTMLSource);
60 }; 60 };
61 61
62 // The handler for JavaScript messages related to the "extensions" view. 62 // The handler for JavaScript messages related to the "extensions" view.
63 class ExtensionsDOMHandler : public WebUIMessageHandler, 63 class ExtensionsDOMHandler : public WebUIMessageHandler,
64 public NotificationObserver, 64 public NotificationObserver,
65 public PackExtensionJob::Client, 65 public PackExtensionJob::Client,
66 public SelectFileDialog::Listener, 66 public SelectFileDialog::Listener,
67 public ExtensionUninstallDialog::Delegate { 67 public ExtensionUninstallDialog::Delegate {
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 210
211 static RefCountedMemory* GetFaviconResourceBytes(); 211 static RefCountedMemory* GetFaviconResourceBytes();
212 212
213 static void RegisterUserPrefs(PrefService* prefs); 213 static void RegisterUserPrefs(PrefService* prefs);
214 214
215 private: 215 private:
216 DISALLOW_COPY_AND_ASSIGN(ExtensionsUI); 216 DISALLOW_COPY_AND_ASSIGN(ExtensionsUI);
217 }; 217 };
218 218
219 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_ 219 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSIONS_UI_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_tts_api.h ('k') | chrome/browser/extensions/image_loading_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698