Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_edit.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/values.h ('k') | chrome/browser/autocomplete/autocomplete_popup_view_gtk.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 bool user_input_in_progress; 97 bool user_input_in_progress;
98 const string16 user_text; 98 const string16 user_text;
99 const string16 keyword; 99 const string16 keyword;
100 const bool is_keyword_hint; 100 const bool is_keyword_hint;
101 }; 101 };
102 102
103 AutocompleteEditModel(OmniboxView* view, 103 AutocompleteEditModel(OmniboxView* view,
104 AutocompleteEditController* controller, 104 AutocompleteEditController* controller,
105 Profile* profile); 105 Profile* profile);
106 ~AutocompleteEditModel(); 106 virtual ~AutocompleteEditModel();
107 107
108 AutocompleteController* autocomplete_controller() const { 108 AutocompleteController* autocomplete_controller() const {
109 return autocomplete_controller_.get(); 109 return autocomplete_controller_.get();
110 } 110 }
111 111
112 void set_popup_model(AutocompletePopupModel* popup_model) { 112 void set_popup_model(AutocompletePopupModel* popup_model) {
113 popup_ = popup_model; 113 popup_ = popup_model;
114 } 114 }
115 115
116 // TODO: The edit and popup should be siblings owned by the LocationBarView, 116 // TODO: The edit and popup should be siblings owned by the LocationBarView,
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 // It has no effect if a keyword is already selected. 550 // It has no effect if a keyword is already selected.
551 bool allow_exact_keyword_match_; 551 bool allow_exact_keyword_match_;
552 552
553 // Last value of InstantCompleteBehavior supplied to |SetSuggestedText|. 553 // Last value of InstantCompleteBehavior supplied to |SetSuggestedText|.
554 InstantCompleteBehavior instant_complete_behavior_; 554 InstantCompleteBehavior instant_complete_behavior_;
555 555
556 DISALLOW_COPY_AND_ASSIGN(AutocompleteEditModel); 556 DISALLOW_COPY_AND_ASSIGN(AutocompleteEditModel);
557 }; 557 };
558 558
559 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_ 559 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_
OLDNEW
« no previous file with comments | « base/values.h ('k') | chrome/browser/autocomplete/autocomplete_popup_view_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698