Turns on the gpu accelerated canvas by default

Contributed by junov@chromium.org 
Turns on the gpu accelerated canvas by default 
BUG=82017
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86510

[Justin Novosad, 2011-05-24 16:42:48]

PTAL

[Avi (use Gerrit), 2011-05-24 16:50:21]

Code LGTM. Please fix the description to use the standard labels:

BUG=
TEST=

so that QA knows how to test it.

[vangelis, 2011-05-24 17:03:32]

one nit, otherwise LGTM

http://codereview.chromium.org/7064032/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7064032/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:368: const char kDisableAccelerated2dCanvas[]  
  = "disable-accelerated-2d-canvas";
The flag definitions are more or less in alphabetical order.  Can you please
move this one with the rest of the kDisable flags?

[Justin Novosad, 2011-05-24 17:29:03]

http://codereview.chromium.org/7064032/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7064032/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:368: const char kDisableAccelerated2dCanvas[]  
  = "disable-accelerated-2d-canvas";
On 2011/05/24 17:03:33, vangelis wrote:
> The flag definitions are more or less in alphabetical order.  Can you please
> move this one with the rest of the kDisable flags?

Done.

[Zhenyao Mo, 2011-05-24 17:31:13]

one nit.  otherwise LGTM

http://codereview.chromium.org/7064032/diff/1/content/browser/gpu/gpu_data_ma...
File content/browser/gpu/gpu_data_manager.cc (left):

http://codereview.chromium.org/7064032/diff/1/content/browser/gpu/gpu_data_ma...
content/browser/gpu/gpu_data_manager.cc:145: switches::kDisableExperimentalWebGL
Here you need to append the switches::kDisableAccelerated2dCanvas.

[Justin Novosad, 2011-05-24 17:39:54]

http://codereview.chromium.org/7064032/diff/1/content/browser/gpu/gpu_data_ma...
File content/browser/gpu/gpu_data_manager.cc (left):

http://codereview.chromium.org/7064032/diff/1/content/browser/gpu/gpu_data_ma...
content/browser/gpu/gpu_data_manager.cc:145: switches::kDisableExperimentalWebGL
On 2011/05/24 17:31:14, Zhenyao Mo wrote:
> Here you need to append the switches::kDisableAccelerated2dCanvas.

Done.

[Ben Goodger (Google), 2011-05-24 19:28:25]

LGTM

[jamesr, 2011-05-24 19:32:12]

Where are the try jobs?

[Justin Novosad, 2011-05-24 19:42:48]

On 2011/05/24 19:32:12, jamesr wrote:
> Where are the try jobs?

I was forced to rename my change because my CL state got corrupted somehow.  I
think gcl didn't like getting killed... Anyways, I did try jobs, the auto-links
just got lost in the process.

Here are the try result:
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/33157
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/28608
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/28255

[Justin Novosad, 2011-05-24 20:03:22]

Could one of you kind reviewers land this for me? I do not have commit rights.

[jamesr, 2011-05-24 20:05:54]

I think this patch does what it intends to, but I'm not sure it's a good idea to
land just yet.  I want to verify that we're doing the right thing w.r.t
extensions, and we still have some worrying regressions in the gpu path relative
to the software path.

[jamesr, 2011-05-24 22:06:44]

(note: I think this'll break a lot of stuff, but if y'all want to try go ahead. 
Ben's LGTM from above covers everything I'm an OWNER for).

[jamesr, 2011-05-24 22:06:45]

(note: I think this'll break a lot of stuff, but if y'all want to try go ahead. 
Ben's LGTM from above covers everything I'm an OWNER for).

[commit-bot: I haz the power, 2011-05-24 23:01:16]

Change committed as 86510