 Chromium Code Reviews
 Chromium Code Reviews Issue 7064027:
  Change calls to undefined property setters to not throw (fixes issue 1355).  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
    
  
    Issue 7064027:
  Change calls to undefined property setters to not throw (fixes issue 1355).  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| OLD | NEW | 
|---|---|
| 1 // Copyright 2009 the V8 project authors. All rights reserved. | 1 // Copyright 2009 the V8 project authors. All rights reserved. | 
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without | 
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are | 
| 4 // met: | 4 // met: | 
| 5 // | 5 // | 
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright | 
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. | 
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above | 
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following | 
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided | 
| 11 // with the distribution. | 11 // with the distribution. | 
| 12 // * Neither the name of Google Inc. nor the names of its | 12 // * Neither the name of Google Inc. nor the names of its | 
| 13 // contributors may be used to endorse or promote products derived | 13 // contributors may be used to endorse or promote products derived | 
| 14 // from this software without specific prior written permission. | 14 // from this software without specific prior written permission. | 
| 15 // | 15 // | 
| 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 
| 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 
| 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 
| 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 
| 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 
| 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 
| 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 
| 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 
| 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 
| 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 
| 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 
| 27 | 27 | 
| 28 // Test that exceptions are thrown when setting properties on object | 28 // Test that exceptions are not thrown when setting properties on object | 
| 29 // that have only a getter in a prototype object. | 29 // that have only a getter in a prototype object. | 
| 30 | 30 | 
| 31 var o = {}; | 31 var o = {}; | 
| 32 var p = {}; | 32 var p = {}; | 
| 33 p.__defineGetter__('x', function(){}); | 33 p.__defineGetter__('x', function(){}); | 
| 34 p.__defineGetter__(0, function(){}); | 34 p.__defineGetter__(0, function(){}); | 
| 35 o.__proto__ = p; | 35 o.__proto__ = p; | 
| 36 | 36 | 
| 37 assertThrows("o.x = 42"); | 37 assertDoesNotThrow("o.x = 42"); | 
| 38 assertThrows("o[0] = 42"); | 38 assertDoesNotThrow("o[0] = 42"); | 
| 39 | 39 | 
| 40 function f() { | 40 function f() { | 
| 41 with(o) { | 41 with(o) { | 
| 42 x = 42; | 42 x = 42; | 
| 43 } | 43 } | 
| 44 } | 44 } | 
| 45 assertThrows("f()"); | 45 assertDoesNotThrow("f()"); | 
| 
Lasse Reichstein
2011/05/25 07:20:53
Cleanup: Just do
  assertDoesNotThrow(f);
It can t
 
Rico
2011/05/25 07:59:28
Ah, thanks, did not know that, changed here and be
 | |
| 46 | 46 | 
| 47 __proto__ = p; | 47 __proto__ = p; | 
| 48 function g() { | 48 function g() { | 
| 49 eval('1'); | 49 eval('1'); | 
| 50 x = 42; | 50 x = 42; | 
| 51 } | 51 } | 
| 52 assertThrows("g()"); | 52 assertDoesNotThrow("g()"); | 
| 53 | 53 | 
| 54 __proto__ = p; | 54 __proto__ = p; | 
| 55 function g2() { | 55 function g2() { | 
| 56 this[0] = 42; | 56 this[0] = 42; | 
| 57 } | 57 } | 
| 58 assertThrows("g2()"); | 58 assertDoesNotThrow("g2()"); | 
| OLD | NEW |