Change calls to undefined property setters to not throw (fixes issue 1355).

Change calls to undefined property setters to not throw (fixes issue 1355).

We currently throw when there is only a getter defined on the
property, but this should only be the case in strict mode.
Committed: http://code.google.com/p/v8/source/detail?r=8054

[Lasse Reichstein, 2011-05-25 07:20:53]

LGTM

http://codereview.chromium.org/7064027/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7064027/diff/1/src/objects.cc#newcode7474
src/objects.cc:7474: Object* setter =
FixedArray::cast(structure)->get(kSetterIndex);
Here I notice a non handlerized pointer in what is otherwise handler based code.
Please wrap it in a handle, for consistency.

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/getter-in-prototyp...
File test/mjsunit/getter-in-prototype.js (right):

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/getter-in-prototyp...
test/mjsunit/getter-in-prototype.js:45: assertDoesNotThrow("f()");
Cleanup: Just do
  assertDoesNotThrow(f);
It can take both a string and a function, so the string is extra complication

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
File test/mjsunit/regress/regress-1355.js (right):

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
test/mjsunit/regress/regress-1355.js:35: });
Or just
 var foo = {get bar() { return 10; }};

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
test/mjsunit/regress/regress-1355.js:44: assertThrows("shouldThrow()");
This test doesn't seem to be as thorough as the one for not throwing - no
indexed properties/elements, no variable lookup (from with or global object).
Please add the other cases too.

[Rico, 2011-05-25 07:59:28]

Comments addressed

http://codereview.chromium.org/7064027/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7064027/diff/1/src/objects.cc#newcode7474
src/objects.cc:7474: Object* setter =
FixedArray::cast(structure)->get(kSetterIndex);
On 2011/05/25 07:20:53, Lasse Reichstein wrote:
> Here I notice a non handlerized pointer in what is otherwise handler based
code.
> Please wrap it in a handle, for consistency.
OK (although we use this a normal pointer two lines down, and only in that and
the previous line)

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/getter-in-prototyp...
File test/mjsunit/getter-in-prototype.js (right):

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/getter-in-prototyp...
test/mjsunit/getter-in-prototype.js:45: assertDoesNotThrow("f()");
On 2011/05/25 07:20:53, Lasse Reichstein wrote:
> Cleanup: Just do
>   assertDoesNotThrow(f);
> It can take both a string and a function, so the string is extra complication
Ah, thanks, did not know that, changed here and below

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
File test/mjsunit/regress/regress-1355.js (right):

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
test/mjsunit/regress/regress-1355.js:35: });
On 2011/05/25 07:20:53, Lasse Reichstein wrote:
> Or just
>  var foo = {get bar() { return 10; }};

For consistency with the bug report I will leave this as is

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
test/mjsunit/regress/regress-1355.js:44: assertThrows("shouldThrow()");
On 2011/05/25 07:20:53, Lasse Reichstein wrote:
> This test doesn't seem to be as thorough as the one for not throwing - no
> indexed properties/elements, no variable lookup (from with or global object).
> Please add the other cases too.
I added the similar test cases to the original file (seems more appropriate).
Except for the 'with' case, since this is not allowed in strict mode :-)

[Lasse Reichstein, 2011-05-25 09:10:25]

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
File test/mjsunit/regress/regress-1355.js (right):

http://codereview.chromium.org/7064027/diff/1/test/mjsunit/regress/regress-13...
test/mjsunit/regress/regress-1355.js:44: assertThrows("shouldThrow()");
You can make a with around a strict function:
 with ({get foo() {}) {
   (function() { "use strict";
      foo = 42;
    })();
 }