Issue 7064022: Update Dr. Memory suppressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064022: Update Dr. Memory suppressions (Closed)

Created:
9 years, 7 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Derek Bruening

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update Dr. Memory suppressions Suppress Sophos and GoogleDesktop reports Move the i#412 suppressions into "known" reports section Remove a few suppressions for fixed issues (and see if the bots remain green) TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86417

Patch Set 1 #

Total comments: 5

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -39 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		7 chunks	+30 lines, -39 lines	5 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Derek Bruening

9 years, 7 months ago (2011-05-24 13:45:32 UTC) #2

the reg query suppression seems too general: don't have just one frame there

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
File tools/valgrind/drmemory/suppressions.txt (left):

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:190: #
http://code.google.com/p/drmemory/issues/detail?id=55
I have in my notes a TODO item to remove this, will check it off

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:251: ADVAPI32.dll!Reg*Value*
I have in my notes a TODO item to go and remove this, will check it off

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
File tools/valgrind/drmemory/suppressions.txt (right):

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:23: # Leaks inside GoogleDesktop
don't we want to report errors to the desktop team?

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:24: # TODO(timurrrr): How/why does it
inject itself into the binaries? WTF?
not surprising for windows apps to end up injecting into every process or doing
other seemingly crazy things just to hook certain events.

http://codereview.chromium.org/7064022/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:349: ADVAPI32.dll!Reg*Value*
this one shouldn't be here: i#358 was fixed.  what does this have to do w/
crypto code?  if this is a reg query input coming from another syscall, please
add more stack frames: no reason to turn off all checking of registry query
routines just for crypto problems

Expand Messages | Collapse Messages