Issue 7064017: Add fast cases for flat comparison to String::Is{Ascii,TwoByte}EqualTo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064017: Add fast cases for flat comparison to String::Is{Ascii,TwoByte}EqualTo. (Closed)

Created:
9 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add fast cases for flat comparison to String::Is{Ascii,TwoByte}EqualTo. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8065

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/objects.cc	View		2 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 7 months ago (2011-05-24 07:14:06 UTC) #3

DBC

http://codereview.chromium.org/7064017/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7064017/diff/1/src/objects.cc#newcode5512
src/objects.cc:5512: if (IsFlat() && IsAsciiRepresentation()) {
CompareChars doesn't require that the two strings have the same width, so you
can speed up the operation for ASCII-UC16 and UC16-ASCII comparisons too.

Expand Messages | Collapse Messages