Issue 7064009: Remove confirmation dialog from BackgroundModeManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7064009: Remove confirmation dialog from BackgroundModeManager. (Closed)

Created:
9 years, 7 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 1 month ago

Reviewers:
Rick Campbell

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Remove confirmation dialog from BackgroundModeManager. After UI review, we decided we don't want to display a confirmation dialog if the user turns off "Let chrome run in the background" when there are no windows open. We'll just silently exit. BUG=76828 TEST=Install background app, close all browser windows, right click status icon and uncheck "Let chrome run...", should see no confirmation dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86376

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -23 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/background_mode_manager.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

Please take a look - nothing but deleted code! Woo!

9 years, 7 months ago (2011-05-23 22:04:28 UTC) #1

LGTM

Expand Messages | Collapse Messages