chrome/browser/resources/print_preview.js - Issue 7064006: Print Preview: Fixing printer list when no printer is installed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview.js

Issue 7064006: Print Preview: Fixing printer list when no printer is installed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing console.log() Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview.js

diff --git a/chrome/browser/resources/print_preview.js b/chrome/browser/resources/print_preview.js

index 9bc3731f709260e2d504da5ab2f1cc35a6328143..a6184e0398deb23847c4cff22b12f09f03373ac0 100644

--- a/chrome/browser/resources/print_preview.js

+++ b/chrome/browser/resources/print_preview.js

@@ -338,7 +338,9 @@ function setPrinters(printers, defaultPrinterIndex) {

addDestinationListOption(printers[i].printerName, printers[i].deviceName,

i == defaultPrinterIndex, false);

}

- addDestinationListOption('','',false, true);

+ if (printers.length != 0)

+ addDestinationListOption('','',false, true);

Lei Zhang 2011/05/23 21:46:19 nit: can you put a space after the comma here and

// Adding option for saving PDF to disk.

addDestinationListOption(localStrings.getString('printToPDF'),

« no previous file with comments | « no previous file | no next file » | no next file with comments »