Print Preview: Fixing printer list when no printer is installed.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 272 matching lines @@
   const LONG_EDGE = 1;
   return !isTwoSided() ? SIMPLEX : LONG_EDGE;
 }
 
 /**
  * Creates a JSON string based on the values in the printer settings.
  *
  * @return {string} JSON string with print job settings.
  */
 function getSettingsJSON() {
-  var printerList = $('printer-list')
-  var selectedPrinter = printerList.selectedIndex;
-  var deviceName = '';
-  if (selectedPrinter >= 0)
-    deviceName = printerList.options[selectedPrinter].value;
   var printAll = $('all-pages').checked;
+  var deviceName = getSelectedPrinterName();
   var printToPDF = (deviceName == PRINT_TO_PDF);
 
   return JSON.stringify({'deviceName': deviceName,
                          'pageRange': getSelectedPageRanges(),
                          'printAll': printAll,
                          'duplex': getDuplexMode(),
                          'copies': getCopies(),
                          'collate': isCollated(),
                          'landscape': isLandscape(),
                          'color': isColor(),
                          'printToPDF': printToPDF});
 }
 
 /**
+ * Returns the name of the selected printer or the empty string if no
+ * printer is selected.
+ */
+function getSelectedPrinterName() {
+  var printerList = $('printer-list')
+  var selectedPrinter = printerList.selectedIndex;
+  var deviceName = '';
+  if (selectedPrinter >= 0)
+    deviceName = printerList.options[selectedPrinter].value;
+  return deviceName;
+}
+
+/**
  * Asks the browser to print the preview PDF based on current print settings.
  */
 function printFile() {
-  chrome.send('print', [getSettingsJSON()]);
+  var printButton = $('print-button');

[Lei Zhang, 2011/05/24 00:58:29]

nit: you don't need |printButton| and |cancelButton| since they are only used
once, or are you are going to use them immediately after in the next CL?

[dpapad, 2011/05/24 01:10:05]

Done.

+  var cancelButton = $('cancel-button');
+  printButton.classList.add('loading');
+  $('print-summary').innerHTML = localStrings.getString('printing');

[Lei Zhang, 2011/05/24 00:58:29]

nit: can you put this one line down?

[dpapad, 2011/05/24 01:10:05]

Done.

+  cancelButton.classList.add('loading');

[dpapad, 2011/05/24 00:23:57]

I will remove all the event listeners here to be safe, when I will rebase
http://codereview.chromium.org/7051040/.

+
+  if (getSelectedPrinterName() != PRINT_TO_PDF)

[Lei Zhang, 2011/05/24 00:58:29]

nit: { } around multi line if blocks.

[dpapad, 2011/05/24 01:10:05]

Done.

+    window.setTimeout(function() { chrome.send('print', [getSettingsJSON()]); },
+                      1000);
+  else
+    chrome.send('print', [getSettingsJSON()]);
 }
 
 /**
  * Asks the browser to generate a preview PDF based on current print settings.
  */
 function requestPrintPreview() {
   isPreviewStillLoading = true;
   setControlsDisabled(true);
   $('dancing-dots').classList.remove('invisible');
   chrome.send('getPreview', [getSettingsJSON()]);
 }
 
 /**
  * Fill the printer list drop down.
  * Called from PrintPreviewHandler::SendPrinterList().
  * @param {Array} printers Array of printer info objects.
  * @param {number} defaultPrinterIndex The index of the default printer.
  */
 function setPrinters(printers, defaultPrinterIndex) {
   var printerList = $('printer-list');
   for (var i = 0; i < printers.length; ++i) {
     addDestinationListOption(printers[i].printerName, printers[i].deviceName,
                              i == defaultPrinterIndex, false);
   }
-  addDestinationListOption('','',false, true);
+
+  if (printers.length != 0)
+    addDestinationListOption('','', false, true);

[Lei Zhang, 2011/05/24 00:58:29]

nit: still need a space after the first comma.

[dpapad, 2011/05/24 01:10:05]

Done.

 
   // Adding option for saving PDF to disk.
   addDestinationListOption(localStrings.getString('printToPDF'),
                            PRINT_TO_PDF, false, false);
-  addDestinationListOption('','',false, true);
+  addDestinationListOption('','', false, true);
 
   // Add an option to manage printers.
   addDestinationListOption(localStrings.getString('managePrinters'),
                            MANAGE_PRINTERS, false, false);
 
   printerList.disabled = false;
   updateControlsWithSelectedPrinterCapabilities();
 }
 
 /**
@@ skipping 544 matching lines @@
     copiesField.value = 1;
   else {
     var newValue = getCopies() + sign * 1;
     if (newValue < copiesField.min || newValue > copiesField.max)
       return;
     copiesField.value = newValue;
   }
   copiesFieldChanged();
 }