chrome/browser/printing/print_preview_message_handler.cc - Issue 7063030: PrintPreview: Print Preview is not staying associated with initiator renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 7063030: PrintPreview: Print Preview is not staying associated with initiator renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated the CL Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_preview_message_handler.cc

diff --git a/chrome/browser/printing/print_preview_message_handler.cc b/chrome/browser/printing/print_preview_message_handler.cc

index 94ea8cf392d824151483a82d56df6f8c26cced34..3a02f47e955ac4ad6a3335ee5fc77da191e267ed 100644

--- a/chrome/browser/printing/print_preview_message_handler.cc

+++ b/chrome/browser/printing/print_preview_message_handler.cc

@@ -12,7 +12,6 @@

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/browser/ui/webui/print_preview_handler.h"

#include "chrome/browser/ui/webui/print_preview_ui.h"

-#include "chrome/browser/ui/webui/print_preview_ui_html_source.h"

#include "chrome/common/print_messages.h"

#include "content/browser/browser_thread.h"

#include "content/browser/renderer_host/render_view_host.h"

@@ -84,8 +83,7 @@ void PrintPreviewMessageHandler::OnPagesReadyForPreview(

PrintPreviewUI* print_preview_ui =

static_cast<PrintPreviewUI*>(print_preview_tab->web_ui());

- PrintPreviewUIHTMLSource* html_source = print_preview_ui->html_source();

- html_source->SetPrintPreviewData(

+ print_preview_ui->SetPrintPreviewData(

std::make_pair(shared_buf, params.data_size));

print_preview_ui->OnPreviewDataIsAvailable(

params.expected_pages_count,

« no previous file with comments | « no previous file | chrome/browser/resources/print_preview.js » ('j') | chrome/browser/ui/webui/print_preview_data_source.h » ('J')