PrintPreview: Print Preview is not staying associated with initiator renderer.

chrome/browser/ui/webui/print_preview_data_source.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_DATA_SOURCE_H_
+#define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_DATA_SOURCE_H_
+#pragma once
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
+
+// PrintPreviewDataSource serves data for chrome://print requests.
+//
+// The format for requesting data is as follows:
+// chrome://print/<PrintPreviewUIAddrStr>/print.pdf
+//
+// Parameters (< > required):
+//    <PrintPreviewUIAddrStr> = Print preview UI identifier.
+//
+// Example:
+//    chrome://print/0xab0123ef/print.pdf
+
+class PrintPreviewDataSource : public ChromeURLDataManager::DataSource {
+ public:
+  PrintPreviewDataSource();

[Lei Zhang, 2011/05/29 10:12:02]

Have you thought about changing this to:
PrintPreviewDataSource(PrintPreviewUI* preview_ui) ?

This can make things much simpler:
- the print preview tab changes can all be reverted, just request
chrome://print/print.pdf as before.
- PrintPreviewDataSource can just check path == "print.pdf" again.
-- A compromised renderer can't access another print preview tab's data via
their print preview UI identifier.

- PreviewDataSourceMap can be a std::map<PrintPreviewUI*,
scoped_refptr<RefCountedBytes> > instead.
- No longer need to do the snprintf() in PrintPreviewUI.
- No longer need |preview_ui_addr_str_| in PrintPreviewUI.

[kmadhusu, 2011/05/29 16:38:04]

Yeah I thought about it. But it will boils down to the original problem. 
(Sample CL which I used to confirm this is :
http://codereview.chromium.org/7082032/)

+
+  // ChromeURLDataManager::DataSource implementation.
+  virtual void StartDataRequest(const std::string& path,
+                                bool is_incognito,
+                                int request_id) OVERRIDE;
+  virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
+
+ private:
+  virtual ~PrintPreviewDataSource();
+
+  DISALLOW_COPY_AND_ASSIGN(PrintPreviewDataSource);
+};
+
+#endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_DATA_SOURCE_H_