Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/ui/webui/print_preview_ui_data_source_unittest.cc

Issue 7063030: PrintPreview: Print Preview is not staying associated with initiator renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
Lei Zhang 2011/05/27 17:26:53 why is this print_preview_ui_data_source_unittest.
kmadhusu 2011/05/27 23:44:42 Testing the print_preview_ui member function behav
Lei Zhang 2011/05/28 00:12:38 Then shouldn't this be print_preview_ui_unittest.c
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/shared_memory.h" 6 #include "base/memory/ref_counted.h"
Lei Zhang 2011/05/27 17:26:53 nit: not needed?
kmadhusu 2011/05/27 23:44:42 Removed.
7 #include "base/memory/ref_counted_memory.h"
7 #include "chrome/browser/printing/print_preview_tab_controller.h" 8 #include "chrome/browser/printing/print_preview_tab_controller.h"
8 #include "chrome/browser/ui/browser_list.h" 9 #include "chrome/browser/ui/browser_list.h"
9 #include "chrome/browser/ui/webui/print_preview_ui.h" 10 #include "chrome/browser/ui/webui/print_preview_ui.h"
10 #include "chrome/browser/ui/webui/print_preview_ui_html_source.h"
11 #include "chrome/common/chrome_switches.h" 11 #include "chrome/common/chrome_switches.h"
12 #include "chrome/test/browser_with_test_window_test.h" 12 #include "chrome/test/browser_with_test_window_test.h"
13 #include "chrome/test/testing_profile.h" 13 #include "chrome/test/testing_profile.h"
14 #include "content/browser/tab_contents/tab_contents.h" 14 #include "content/browser/tab_contents/tab_contents.h"
15 15
16 typedef BrowserWithTestWindowTest PrintPreviewUIHTMLSourceTest; 16 namespace {
17
18 const unsigned char blob1[] =
19 "12346102356120394751634516591348710478123649165419234519234512349134";
20
21 } // namespace
22
23 typedef BrowserWithTestWindowTest PrintPreviewUIDataSourceTest;
17 24
18 // Create/Get a preview tab for initiator tab. 25 // Create/Get a preview tab for initiator tab.
19 TEST_F(PrintPreviewUIHTMLSourceTest, PrintPreviewData) { 26 TEST_F(PrintPreviewUIDataSourceTest, PrintPreviewData) {
20 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS) 27 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
21 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview); 28 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview);
22 #endif 29 #endif
23 ASSERT_TRUE(browser()); 30 ASSERT_TRUE(browser());
24 BrowserList::SetLastActive(browser()); 31 BrowserList::SetLastActive(browser());
25 ASSERT_TRUE(BrowserList::GetLastActive()); 32 ASSERT_TRUE(BrowserList::GetLastActive());
26 33
27 browser()->NewTab(); 34 browser()->NewTab();
28 TabContents* initiator_tab = browser()->GetSelectedTabContents(); 35 TabContents* initiator_tab = browser()->GetSelectedTabContents();
29 ASSERT_TRUE(initiator_tab); 36 ASSERT_TRUE(initiator_tab);
30 37
31 scoped_refptr<printing::PrintPreviewTabController> 38 scoped_refptr<printing::PrintPreviewTabController>
32 controller(new printing::PrintPreviewTabController()); 39 controller(new printing::PrintPreviewTabController());
33 ASSERT_TRUE(controller); 40 ASSERT_TRUE(controller);
34 41
35 TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab); 42 TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab);
36 43
37 EXPECT_NE(initiator_tab, preview_tab); 44 EXPECT_NE(initiator_tab, preview_tab);
38 EXPECT_EQ(2, browser()->tab_count()); 45 EXPECT_EQ(2, browser()->tab_count());
39 46
40 PrintPreviewUI* preview_ui = 47 PrintPreviewUI* preview_ui =
41 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui()); 48 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
42 ASSERT_TRUE(preview_ui != NULL); 49 ASSERT_TRUE(preview_ui != NULL);
43 PrintPreviewUIHTMLSource* html_source = preview_ui->html_source();
44 50
45 PrintPreviewUIHTMLSource::PrintPreviewData data; 51 scoped_refptr<RefCountedBytes> data(new RefCountedBytes);
46 html_source->GetPrintPreviewData(&data); 52 preview_ui->GetPrintPreviewData(&data);
47 EXPECT_EQ(NULL, data.first); 53 EXPECT_EQ(NULL, data->front());
48 EXPECT_EQ(0U, data.second); 54 EXPECT_EQ(0U, data->size());
49 55
50 PrintPreviewUIHTMLSource::PrintPreviewData dummy_data = 56 std::vector<unsigned char> preview_data(blob1, blob1 + sizeof(blob1));
51 std::make_pair(new base::SharedMemory(), 1234); 57 scoped_refptr<RefCountedBytes> dummy_data(new RefCountedBytes(preview_data));
52 58
53 html_source->SetPrintPreviewData(dummy_data); 59 preview_ui->SetPrintPreviewData(dummy_data.get());
54 html_source->GetPrintPreviewData(&data); 60 preview_ui->GetPrintPreviewData(&data);
55 EXPECT_EQ(dummy_data, data); 61 EXPECT_EQ(dummy_data->size(), data->size());
62 EXPECT_EQ(dummy_data.get(), data.get());
56 63
57 // This should not cause any memory leaks. 64 // This should not cause any memory leaks.
58 dummy_data.first = new base::SharedMemory(); 65 dummy_data = new RefCountedBytes();
59 html_source->SetPrintPreviewData(dummy_data); 66 preview_ui->SetPrintPreviewData(dummy_data);
60 } 67 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698