PrintPreview: Print Preview is not staying associated with initiator renderer.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 
 // The total page count of the previewed document regardless of which pages the
 // user has selected.
 var totalPageCount = -1;
 
@@ skipping 474 matching lines @@
   updateCopiesButtonsState();
 }
 
 /**
  * Update the print preview when new preview data is available.
  * Create the PDF plugin as needed.
  * Called from PrintPreviewUI::PreviewDataIsAvailable().
  * @param {number} pageCount The expected total pages count.
  * @param {string} jobTitle The print job title.
  * @param {boolean} modifiable If the preview is modifiable.
- *
+ * @param {string} previewUIId Preview UI identifier.

[Lei Zhang, 2011/05/27 17:26:53]

nit: can you just call this "previewUid" here and elsewhere?

[kmadhusu, 2011/05/27 23:44:42]

Done.

  */
-function updatePrintPreview(pageCount, jobTitle, modifiable) {
+function updatePrintPreview(pageCount, jobTitle, modifiable, previewUIId) {
   var tempPrintSettings = new PrintSettings();
   tempPrintSettings.save();
 
   previewModifiable = modifiable;
 
   if (totalPageCount == -1)
     totalPageCount = pageCount;
 
   if (previouslySelectedPages.length == 0)
     for (var i = 0; i < totalPageCount; i++)
@@ skipping 13 matching lines @@
       return;
     }
   }
 
   if (getSelectedPagesValidityLevel() != 1)
     pageRangesFieldChanged();
 
   // Update the current tab title.
   document.title = localStrings.getStringF('printPreviewTitleFormat', jobTitle);
 
-  createPDFPlugin();
+  createPDFPlugin(previewUIId);
   updatePrintSummary();
   updatePrintButtonState();
   addEventListeners();
 }
 
 /**
  * Create the PDF plugin or reload the existing one.
+ * @param {string} previewUIId Preview UI identifier.
  */
-function createPDFPlugin() {
+function createPDFPlugin(previewUIId) {
   // Enable the print button.
   if (!$('printer-list').disabled) {
     $('print-button').disabled = false;
   }
 
   var pdfViewer = $('pdf-viewer');
   if (pdfViewer) {
     // Older version of the PDF plugin may not have this method.
     // TODO(thestig) Eventually remove this check.
     if (pdfViewer.goToPage) {
       // Need to call this before the reload(), where the plugin resets its
       // internal page count.
       pdfViewer.goToPage('0');
     }
     pdfViewer.reload();
     pdfViewer.grayscale(!isColor());
     return;
   }
 
   var pdfPlugin = document.createElement('embed');
   pdfPlugin.setAttribute('id', 'pdf-viewer');
   pdfPlugin.setAttribute('type', 'application/pdf');
-  pdfPlugin.setAttribute('src', 'chrome://print/print.pdf');
+  pdfPlugin.setAttribute('src', 'chrome://print/print.pdf/' + previewUIId);

[Lei Zhang, 2011/05/27 17:26:53]

I thought we were going to do chrome://print/print.pdf?ab0123ef

[kmadhusu, 2011/05/27 23:44:42]

(repeating our in-person conversation) There is no specific URL format.
Considering other issues, I have changed the format to
"chrome://print/ab0123ef/print.pdf"

   var mainView = $('mainview');
   mainView.appendChild(pdfPlugin);
   pdfPlugin.onload('onPDFLoad()');
 
   // Older version of the PDF plugin may not have this method.
   // TODO(thestig) Eventually remove this check.
   if (pdfPlugin.removePrintButton) {
     pdfPlugin.removePrintButton();
   }
 
@@ skipping 402 matching lines @@
   this.isLandscape = '';
 }
 
 /**
  * Takes a snapshot of the print settings.
  */
 PrintSettings.prototype.save = function() {
   this.deviceName = getSelectedPrinterName();
   this.isLandscape = isLandscape();
 }