Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7063029: Options: Style cleanup - id attribute first. (Closed)

Created:
9 years, 7 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
csilv
CC:
chromium-reviews, GeorgeY, tfarina, arv (Not doing code reviews), Ilya Sherman, dhollowa
Visibility:
Public.

Description

Options: Style cleanup - id attribute first. Also remove some unecessary blank lines. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86534

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -239 lines) Patch
M chrome/browser/resources/options/about_page.html View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/alert_overlay.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_address_overlay.html View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.html View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/certificate_backup_overlay.html View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/certificate_edit_ca_trust_overlay.html View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/certificate_import_error_overlay.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/certificate_manager.html View 6 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/resources/options/certificate_restore_overlay.html View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options.html View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_chewing_options.html View 9 chunks +21 lines, -33 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_customize_modifier_keys_overlay.html View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_hangul_options.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_mozc_options.html View 10 chunks +21 lines, -29 lines 0 comments Download
M chrome/browser/resources/options/chromeos/language_pinyin_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/proxy.html View 1 3 chunks +85 lines, -55 lines 0 comments Download
M chrome/browser/resources/options/chromeos/system_options.html View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 11 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/cookies_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/instant_confirm_overlay.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/personal_options.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
9 years, 7 months ago (2011-05-25 00:02:01 UTC) #1
csilv
LGTM http://codereview.chromium.org/7063029/diff/1/chrome/browser/resources/options/chromeos/proxy.html File chrome/browser/resources/options/chromeos/proxy.html (right): http://codereview.chromium.org/7063029/diff/1/chrome/browser/resources/options/chromeos/proxy.html#newcode54 chrome/browser/resources/options/chromeos/proxy.html:54: <span i18n-content="proxyPort"></span></td><td> Line wrap the </td> and <td> ...
9 years, 7 months ago (2011-05-25 00:20:59 UTC) #2
James Hawkins
9 years, 7 months ago (2011-05-25 00:27:25 UTC) #3 
http://codereview.chromium.org/7063029/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/proxy.html (right):

http://codereview.chromium.org/7063029/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/proxy.html:54: <span
i18n-content="proxyPort"></span></td><td>
On 2011/05/25 00:21:00, csilv wrote:
> Line wrap the </td> and <td> at the end of this line.

Done.

http://codereview.chromium.org/7063029/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/proxy.html:84: <span
i18n-content="proxyPort"></span></td><td>
On 2011/05/25 00:21:00, csilv wrote:
> Line wrap the </td> and <td> at the end of this line.

Done.

Powered by Google App Engine
This is Rietveld 408576698