Issue 7063021: Modify use of RelocInfo::CODE_TARGET_WITH_ID in full-codegen to make it the same on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7063021: Modify use of RelocInfo::CODE_TARGET_WITH_ID in full-codegen to make it the same on all platforms. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Modify use of RelocInfo::CODE_TARGET_WITH_ID in full-codegen to make it the same on all platforms. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8039

Patch Set 1 #

Total comments: 1

Patch Set 2 : add a blank line on all platforms. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -68 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	19 chunks	+30 lines, -34 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	19 chunks	+30 lines, -34 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 7 months ago (2011-05-24 13:39:09 UTC) #2

LGTM

http://codereview.chromium.org/7063021/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (left):

http://codereview.chromium.org/7063021/diff/1/src/x64/full-codegen-x64.cc#old...
src/x64/full-codegen-x64.cc:45: 
I would go the other way and have two spaces on all platform.

Expand Messages | Collapse Messages