Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7063017: Rename TypeRecording...Stub into ...Stub. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Rename TypeRecording...Stub into ...Stub. There is no need for this long name. Committed: http://code.google.com/p/v8/source/detail?r=8031

Patch Set 1 #

Total comments: 86

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -632 lines) Patch
M src/arm/code-stubs-arm.h View 8 chunks +31 lines, -31 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 36 chunks +87 lines, -91 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 8 chunks +29 lines, -31 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 33 chunks +75 lines, -80 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic.h View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ic.cc View 1 12 chunks +62 lines, -63 lines 0 comments Download
M src/log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.h View 8 chunks +31 lines, -31 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 36 chunks +80 lines, -81 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/objects.h View 3 chunks +13 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 3 chunks +16 lines, -15 lines 0 comments Download
M src/spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-info.cc View 5 chunks +37 lines, -37 lines 0 comments Download
M src/x64/code-stubs-x64.h View 7 chunks +31 lines, -31 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 31 chunks +75 lines, -80 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 7 months ago (2011-05-24 11:10:02 UTC) #1
Søren Thygesen Gjesse
LGTM with style/indentation fixed. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1710 src/arm/code-stubs-arm.cc:1710: Handle<Code> GetUnaryOpStub(int key, Indentation. http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newcode1810 ...
9 years, 7 months ago (2011-05-24 11:33:11 UTC) #2
fschneider
9 years, 7 months ago (2011-05-24 12:16:41 UTC) #3 
http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1710: Handle<Code> GetUnaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1810: void
UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1825: void
UnaryOpStub::GenerateSmiCodeBitNot(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1863: void UnaryOpStub::GenerateHeapNumberStubBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits on one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1873: void
UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1991: void UnaryOpStub::GenerateGenericCodeFallback(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits on one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2008: Handle<Code> GetBinaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Full indentation (not 4 spaces) or int key on a separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2096: void BinaryOpStub::GenerateSmiSmiOperation(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2222: void
BinaryOpStub::GenerateFPOperation(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2436: void
BinaryOpStub::GenerateSmiCode(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> MacroAssembler* masm, should go on a separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2766: (result_type_ <= BinaryOpIC::INT32) ?
&transition
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2769: __ b(mi, (result_type_ <= BinaryOpIC::INT32) ?
&transition
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2972: void BinaryOpStub::GenerateHeapResultAllocation(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits full indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:520: Handle<Code> GetUnaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:623: void
UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:707: void
UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:743: void UnaryOpStub::GenerateHeapNumberCodeBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Move MacroAssembler* masm, up one line and full indent of Label* slow?

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:840: void UnaryOpStub::GenerateGenericCodeFallback(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:892: void
BinaryOpStub::GenerateTypeTransitionWithSavedArgs(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:970: void
BinaryOpStub::GenerateSmiCode(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> MacroAssembler* masm, on a separate line

Done.

http://codereview.chromium.org/7063017/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2203
src/ic.cc:2203: UnaryOpIC::TypeInfo UnaryOpIC::ComputeNewType(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Possibly reorganize arguments.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2264
src/ic.cc:2264: BinaryOpIC::TypeInfo BinaryOpIC::JoinTypes(BinaryOpIC::TypeInfo
x,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2279
src/ic.cc:2279: BinaryOpIC::TypeInfo BinaryOpIC::GetTypeInfo(Handle<Object>
left,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/ic.cc#newcode2373
src/ic.cc:2373: Handle<Code> GetBinaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:1907: void
UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:1922: void
UnaryOpStub::GenerateSmiCodeBitNot(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:1960: void
UnaryOpStub::GenerateHeapNumberStubBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:1970: void
UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:2003: void
UnaryOpStub::GenerateHeapNumberCodeBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Reorganize arguments?

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:2104: Handle<Code> GetBinaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Full indentation or int key on separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:2193: void BinaryOpStub::GenerateSmiSmiOperation(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:2348: void
BinaryOpStub::GenerateFPOperation(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/mips/code-stubs-mips.cc#new...
src/mips/code-stubs-mips.cc:2564: void
BinaryOpStub::GenerateSmiCode(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> MacroAssembler* masm, on separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:409: Handle<Code> GetUnaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:487: void
UnaryOpStub::GenerateSmiCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:501: void UnaryOpStub::GenerateSmiCodeBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits full intentation?

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:549: void
UnaryOpStub::GenerateHeapNumberCodeSub(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:590: void UnaryOpStub::GenerateHeapNumberCodeBitNot(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits full indentation?

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:643: void UnaryOpStub::GenerateGenericCodeFallback(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits one line?

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:684: Handle<Code> GetBinaryOpStub(int key,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Full intentation or int key on separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:773: void
BinaryOpStub::GenerateSmiCode(MacroAssembler* masm,
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> MacroAssembler* masm, on separate line.

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:923: void BinaryOpStub::GenerateFloatingPointCode(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits full indentation?

Done.

http://codereview.chromium.org/7063017/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:1228: void BinaryOpStub::GenerateHeapResultAllocation(
On 2011/05/24 11:33:11, Søren Gjesse wrote:
> Fits full indentation?

Done.

Powered by Google App Engine
This is Rietveld 408576698