Issue 7063015: Swap processes on reload if a hosted app has been installed/uninstalled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7063015: Swap processes on reload if a hosted app has been installed/uninstalled. (Closed)

Created:
9 years, 7 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
jam, Matt Perry

CC:
chromium-reviews, Avi (use Gerrit), Jói, Erik does not do reviews, Paweł Hajdan Jr., jam, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Swap processes on reload if a hosted app has been installed/uninstalled. Also ensure the task manager only shows "App" if the process is an app process. BUG=80621 TEST=AppApiTest.ReloadIntoAppProcess TEST=TaskManagerBrowserTest.NoticeHostedAppTabs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86566

Patch Set 1 #

Patch Set 2 : Fix test timeout. #

Patch Set 3 : Fix compile on Windows #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -15 lines)			Patch
M	chrome/browser/extensions/app_process_apitest.cc	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_browsertest.cc	View	1	3 chunks	+52 lines, -1 line	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View		2 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	content/browser/site_instance.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/browser/site_instance.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View		3 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Thanks Matt. Presubmit says I need approval from an owner-- John, can you take a ...

9 years, 7 months ago (2011-05-24 22:55:46 UTC) #3

content lgtm

Expand Messages | Collapse Messages