Allowing project name to be used to select groups of bots.

Allowing project name to be used to select groups of bots.

BUG=79546
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86460

[M-A Ruel, 2011-05-24 17:29:42]

non-enthusiast lgtm

http://codereview.chromium.org/7063004/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/7063004/diff/1/presubmit_support.py#newcode883
presubmit_support.py:883: context = {'project': project}
I don't like relying on a global variable. I'd prefer to pass it as a parameter
to the eval function but that is not backward compatible. The only backward
compatible way is to trap the TypeError that is thrown at line 891 and try again
without arg.

[bradn, 2011-05-24 18:49:47]

PTAL

Why the lack of enthusiasm? You're concerned about supporting this option?


On Tue, May 24, 2011 at 10:29 AM, <maruel@chromium.org> wrote:

> non-enthusiast lgtm
>
>
> http://codereview.chromium.org/7063004/diff/1/presubmit_support.py
> File presubmit_support.py (right):
>
>
> http://codereview.chromium.org/7063004/diff/1/presubmit_support.py#newcode883
> presubmit_support.py:883: context = {'project': project}
> I don't like relying on a global variable. I'd prefer to pass it as a
> parameter to the eval function but that is not backward compatible. The
> only backward compatible way is to trap the TypeError that is thrown at
> line 891 and try again without arg.
>
>
> http://codereview.chromium.org/7063004/
>

[M-A Ruel, 2011-05-24 18:52:59]

On 2011/05/24 18:49:47, bradn wrote:
> PTAL
> 
> Why the lack of enthusiasm? You're concerned about supporting this option?

Global variable. As someone is reading a PRESUBMIT.py, how is he supposed to
know that 'project' is a global variable? By having it an argument, it's much
simpler.

[M-A Ruel, 2011-05-24 18:53:05]

and lgtm

[Marc-Antoine Ruel (Google), 2011-05-25 20:24:47]

************* Module tests.presubmit_unittest
E1120:664:PresubmitUnittest.testGetTrySlavesExecuter: No value passed for
parameter 'project' in function call
E1120:666:PresubmitUnittest.testGetTrySlavesExecuter: No value passed for
parameter 'project' in function call
E1120:684:PresubmitUnittest.testGetTrySlavesExecuter: No value passed for
parameter 'project' in function call
E1120:711:PresubmitUnittest.testDoGetTrySlaves: No value passed for parameter
'output_stream' in function call
E1120:715:PresubmitUnittest.testDoGetTrySlaves: No value passed for parameter
'output_stream' in function call

[Marc-Antoine Ruel (Google), 2011-05-25 20:26:52]

And


.............................................................................E.....E.......
======================================================================
ERROR: testDoGetTrySlaves (__main__.PresubmitUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/seagate1.5tb/maruel/src/depot_tools/third_party/pymox/mox.py", line
1618, in new_method
    func(self, *args, **kwargs)
  File "tests/presubmit_unittest.py", line 712, in testDoGetTrySlaves
    None, False, output))
TypeError: DoGetTrySlaves() takes exactly 6 arguments (5 given)

======================================================================
ERROR: testGetTrySlavesExecuter (__main__.PresubmitUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/seagate1.5tb/maruel/src/depot_tools/third_party/pymox/mox.py", line
1618, in new_method
    func(self, *args, **kwargs)
  File "tests/presubmit_unittest.py", line 664, in testGetTrySlavesExecuter
    self.assertEqual([], executer.ExecPresubmitScript('', ''))
TypeError: ExecPresubmitScript() takes exactly 3 arguments (2 given)

----------------------------------------------------------------------
Ran 91 tests in 0.162s

FAILED (errors=2)

[bradn, 2011-05-26 01:27:08]

Aahh, sorry fixing....


On Wed, May 25, 2011 at 1:26 PM, <maruel@google.com> wrote:

> And
>
>
>
>
.............................................................................E.....E.......
> ======================================================================
> ERROR: testDoGetTrySlaves (__main__.PresubmitUnittest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "/mnt/seagate1.5tb/maruel/src/depot_tools/third_party/pymox/mox.py",
> line
> 1618, in new_method
>    func(self, *args, **kwargs)
>  File "tests/presubmit_unittest.py", line 712, in testDoGetTrySlaves
>    None, False, output))
> TypeError: DoGetTrySlaves() takes exactly 6 arguments (5 given)
>
> ======================================================================
> ERROR: testGetTrySlavesExecuter (__main__.PresubmitUnittest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "/mnt/seagate1.5tb/maruel/src/depot_tools/third_party/pymox/mox.py",
> line
> 1618, in new_method
>    func(self, *args, **kwargs)
>  File "tests/presubmit_unittest.py", line 664, in testGetTrySlavesExecuter
>    self.assertEqual([], executer.ExecPresubmitScript('', ''))
> TypeError: ExecPresubmitScript() takes exactly 3 arguments (2 given)
>
> ----------------------------------------------------------------------
> Ran 91 tests in 0.162s
>
> FAILED (errors=2)
>
>
>
> http://codereview.chromium.org/7063004/
>