Move media library AutoTaskRunner to base and rename ScopedTaskRunner.

media/filters/decoder_base.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A base class that provides the plumbing for a decoder filters.
 
 #ifndef MEDIA_FILTERS_DECODER_BASE_H_
 #define MEDIA_FILTERS_DECODER_BASE_H_
 
 #include <deque>
@@ skipping 84 matching lines @@
   // a fatal error.  The derived class should NOT call the filter host's
   // InitializationComplete() method.  If this method returns true, then the
   // base class will call the host to complete initialization.
   virtual void DoInitialize(DemuxerStream* demuxer_stream, bool* success,
                             Task* done_cb) = 0;
 
   // Method that may be implemented by the derived class if desired.  It will
   // be called from within the Filter::Stop() method prior to stopping the
   // base class.
   virtual void DoStop(Task* done_cb) {
-    AutoTaskRunner done_runner(done_cb);
+    done_cb->Run();

[dmac, 2011/05/26 17:55:42]

Maybe I'm being slow this morning, but why is this not a ScopedTaskRunnner now?

[Wez, 2011/05/26 18:48:21]

Reverted.

I was thinking of this as an unnecessary dependency; there's only one code-path
so |done_cb->Run(); delete done_cb;| seemed cleaner.  I'm not entirely sure why
this method has a default implementation at all, given that its peers don't.

+    delete done_cb;
   }
 
   // Derived class can implement this method and perform seeking logic prior
   // to the base class.
   virtual void DoSeek(base::TimeDelta time, Task* done_cb) = 0;
 
   // Method that must be implemented by the derived class.  If the decode
   // operation produces one or more outputs, the derived class should call
   // the EnequeueResult() method from within this method.
   virtual void DoDecode(Buffer* input) = 0;
@@ skipping 186 matching lines @@
 
   // Callback to update pipeline statistics.
   scoped_ptr<StatisticsCallback> statistics_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBase);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_DECODER_BASE_H_