Issue 7062012: Fixing unit tests to match --project changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7062012: Fixing unit tests to match --project changes. (Closed)

Created:
9 years, 7 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Marc-Antoine Ruel (Google), M-A Ruel

CC:
chromium-reviews, Dirk Pranke

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fixing unit tests to match --project changes. BUG=79546 TEST=None R=maruel@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86837

Patch Set 3 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -7 lines)			Patch
	M	tests/presubmit_unittest.py	View	1 2	5 chunks	+29 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

still lgtm http://codereview.chromium.org/7062012/diff/1/tests/presubmit_unittest.py File tests/presubmit_unittest.py (right): http://codereview.chromium.org/7062012/diff/1/tests/presubmit_unittest.py#newcode666 tests/presubmit_unittest.py:666: [], executer.ExecPresubmitScript('def foo():\n return\n', '', '')) You ...

9 years, 7 months ago (2011-05-26 12:49:48 UTC) #2

bradn

9 years, 7 months ago (2011-05-26 16:52:06 UTC) #3

http://codereview.chromium.org/7062012/diff/1/tests/presubmit_unittest.py
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/7062012/diff/1/tests/presubmit_unittest.py#new...
tests/presubmit_unittest.py:666: [], executer.ExecPresubmitScript('def foo():\n 
return\n', '', ''))
On 2011/05/26 12:49:49, Marc-Antoine Ruel wrote:
> You don't want to add a quick test for 'def foo(project):\n  return project\n'
?

Done.

http://codereview.chromium.org/7062012/diff/1/tests/presubmit_unittest.py#new...
tests/presubmit_unittest.py:718: False, output))
On 2011/05/26 12:49:49, Marc-Antoine Ruel wrote:
> Please use space instead.

Done.

Expand Messages | Collapse Messages

Issue 7062012: Fixing unit tests to match --project changes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages