Issue 7062007: Avoid calling ToObject on JSFunction receiver arguments for Function.call and Function.apply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7062007: Avoid calling ToObject on JSFunction receiver arguments for Function.call and Function.apply. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Avoid calling ToObject on JSFunction receiver arguments for Function.call and Function.apply. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8000

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 4

Patch Set 3 : Add static asserts. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -38 lines)			Patch
M	src/arm/builtins-arm.cc	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1 2	2 chunks	+13 lines, -18 lines	0 comments	Download
M	src/mips/builtins-mips.cc	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1 2	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 7 months ago (2011-05-23 14:58:01 UTC) #2

LGTM

http://codereview.chromium.org/7062007/diff/1001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/7062007/diff/1001/src/ia32/builtins-ia32.cc#ne...
src/ia32/builtins-ia32.cc:618: __ CmpObjectType(ebx, FIRST_JS_OBJECT_TYPE, ecx);
add an assertion that LAST_TYPE == JS_FUNCTION_TYPE?

http://codereview.chromium.org/7062007/diff/1001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):

http://codereview.chromium.org/7062007/diff/1001/src/mips/builtins-mips.cc#ne...
src/mips/builtins-mips.cc:1226: __ Branch(&shift_arguments, ge, a3,
Operand(FIRST_JS_OBJECT_TYPE));
add an assertion that LAST_TYPE == JS_FUNCTION_TYPE?

http://codereview.chromium.org/7062007/diff/1001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

http://codereview.chromium.org/7062007/diff/1001/src/x64/builtins-x64.cc#newc...
src/x64/builtins-x64.cc:677: __ j(above_equal, &shift_arguments);
add an assertion that LAST_TYPE == JS_FUNCTION_TYPE?

http://codereview.chromium.org/7062007/diff/1001/src/x64/builtins-x64.cc#newc...
src/x64/builtins-x64.cc:844: __ j(above_equal, &push_receiver);
add an assertion that LAST_TYPE == JS_FUNCTION_TYPE?

Expand Messages | Collapse Messages