Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 7061008: Create template system for strict-mode tests. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Create template system for strict-mode tests. This makes it possible to get total coverage without creating thousands of individual test files. Committed: http://code.google.com/p/v8/source/detail?r=7985

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove debug print. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -1163 lines) Patch
M preparser/preparser-process.cc View 1 4 chunks +51 lines, -30 lines 0 comments Download
M src/preparser.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M test/preparser/preparser.expectation View 2 chunks +2 lines, -36 lines 0 comments Download
D test/preparser/strict-arguments-argument.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-argument-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-arguments-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-catch.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/preparser/strict-arguments-func.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-func-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-arguments-funcexp.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-op-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-postfix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-prefix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-arguments-var.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-argument.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-argument-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-eval-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-catch.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/preparser/strict-eval-func.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-func-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-eval-funcexp.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-op-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-postfix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-prefix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-eval-var.js View 1 chunk +0 lines, -33 lines 0 comments Download
A test/preparser/strict-identifiers.pyt View 1 chunk +199 lines, -0 lines 0 comments Download
D test/preparser/strict-yield-argument.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-argument-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-yield-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-catch.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/preparser/strict-yield-func.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-func-own.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/preparser/strict-yield-funcexp.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-op-assign.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-postfix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-prefix.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/preparser/strict-yield-var.js View 1 chunk +0 lines, -33 lines 0 comments Download
M test/preparser/testcfg.py View 4 chunks +47 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 7 months ago (2011-05-23 07:57:32 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/7061008/diff/1/preparser/preparser-process.cc File preparser/preparser-process.cc (right): http://codereview.chromium.org/7061008/diff/1/preparser/preparser-process.cc#newcode325 preparser/preparser-process.cc:325: printf("SOURCE:\n%s\n---\n", source); Remove debug printing?
9 years, 7 months ago (2011-05-23 10:31:13 UTC) #2
Lasse Reichstein
9 years, 7 months ago (2011-05-23 10:35:19 UTC) #3
http://codereview.chromium.org/7061008/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/7061008/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:325: printf("SOURCE:\n%s\n---\n", source);
Let's :)

Powered by Google App Engine
This is Rietveld 408576698