Mac: Make ProfileMenuButton a MenuButton.

Mac: Make ProfileMenuButton a MenuButton.

Increases code reuse a bit. To make this work, give MenuButton a
-menuRect function, since ProfileMenuButton is larger than the
area it draws in.

Also potentially addresses the problem described inhttp://waffle.wootest.net/2007/08/07/popping-up-a-menu-in-cocoa/
which might be 10.5-only.

xib changes: Remove the old popup button-based PopupMenuButton, re-add
it by duplicating the new tab button, changing the resize anchor to the
upper-right corner, and changing the cell to ClickHoldButtonCell.

BUG=83169
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86295

[Miranda Callahan, 2011-05-23 16:10:10]

LGTM, but wait for sail or vtl to weigh in...

[viettrungluu, 2011-05-23 16:52:19]

LGTM w/nit.

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/profile...
File chrome/browser/ui/cocoa/profile_menu_button.mm (right):

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/profile...
chrome/browser/ui/cocoa/profile_menu_button.mm:354: - (NSMenu *)attachedMenu {
Nit: no space before the *.

[sail, 2011-05-23 17:51:07]

LGTM. Thanks for doing this!

A couple things that might need tweaking (I can do this later)
  - make sure that the menu shows on mouse down, not mouse up
  - make sure that the menu shows up close to the bottom of the button

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
File chrome/browser/ui/cocoa/menu_button.mm (left):

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
chrome/browser/ui/cocoa/menu_button.mm:116: NSRect frame = [self
convertRect:[self frame]
This old convertRect:fromView: looks weird. Do you know why it was written like
that?

[Nico, 2011-05-23 18:00:33]

The menu should show up on mouse-down already, and is positioned similar to
where it was before (it's 2px farther up I think).

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
File chrome/browser/ui/cocoa/menu_button.mm (left):

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
chrome/browser/ui/cocoa/menu_button.mm:116: NSRect frame = [self
convertRect:[self frame]
On 2011/05/23 17:51:08, sail wrote:
> This old convertRect:fromView: looks weird. Do you know why it was written
like
> that?

Trung sometimes does things like this, just to keep us on our toes.

[viettrungluu, 2011-05-23 18:22:12]

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
File chrome/browser/ui/cocoa/menu_button.mm (left):

http://codereview.chromium.org/7061001/diff/1/chrome/browser/ui/cocoa/menu_bu...
chrome/browser/ui/cocoa/menu_button.mm:116: NSRect frame = [self
convertRect:[self frame]
On 2011/05/23 18:00:33, Nico wrote:
> On 2011/05/23 17:51:08, sail wrote:
> > This old convertRect:fromView: looks weird. Do you know why it was written
> like
> > that?
> 
> Trung sometimes does things like this, just to keep us on our toes.

By which Nico really means: I wasn't really a Mac programmer when I wrote this,
and didn't know about -bounds (I swear!).