PrerenderTracker Cleanup

Cleanup PrerenderTracker in response to comments in
http://codereview.chromium.org/7038012/.

BUG=83062
TEST=PrerenderStatusManagerTests, PrerenderBrowserTests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86342

[mmenke, 2011-05-23 16:54:56]

dominich:  CCing you just in case this affects your change.

[cbentzel, 2011-05-23 17:02:23]

http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
File chrome/browser/prerender/prerender_tracker.cc (right):

http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
chrome/browser/prerender/prerender_tracker.cc:50: SetFinalStatus(child_id,
route_id, FINAL_STATUS_USED, &actual_final_status);
Ah, I thought you could get away with just doing

return SetFinalStatus(child_id, route_id, FINAL_STATUS_USED, NULL);

here. 

Why is that not sufficient?

[mmenke, 2011-05-23 17:31:46]

http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
File chrome/browser/prerender/prerender_tracker.cc (right):

http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
chrome/browser/prerender/prerender_tracker.cc:50: SetFinalStatus(child_id,
route_id, FINAL_STATUS_USED, &actual_final_status);
On 2011/05/23 17:02:23, cbentzel wrote:
> Ah, I thought you could get away with just doing
> 
> return SetFinalStatus(child_id, route_id, FINAL_STATUS_USED, NULL);
> 
> here. 
> 
> Why is that not sufficient?

Done.

Inertia, basically.  Unit tests quite deliberately don't depend on the current
behavior, so it's a simple change.

[cbentzel, 2011-05-23 19:28:09]

LGTM

On 2011/05/23 17:31:46, Matt Menke wrote:
>
http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
> File chrome/browser/prerender/prerender_tracker.cc (right):
> 
>
http://codereview.chromium.org/7060012/diff/7/chrome/browser/prerender/preren...
> chrome/browser/prerender/prerender_tracker.cc:50: SetFinalStatus(child_id,
> route_id, FINAL_STATUS_USED, &actual_final_status);
> On 2011/05/23 17:02:23, cbentzel wrote:
> > Ah, I thought you could get away with just doing
> > 
> > return SetFinalStatus(child_id, route_id, FINAL_STATUS_USED, NULL);
> > 
> > here. 
> > 
> > Why is that not sufficient?
> 
> Done.
> 
> Inertia, basically.  Unit tests quite deliberately don't depend on the current
> behavior, so it's a simple change.

[commit-bot: I haz the power, 2011-05-23 21:28:00]

Change committed as 86342