Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: media/audio/win/audio_manager_win.cc

Issue 7060011: Adding GetAudioInputDeviceNames to AudioManager, this function is supposed to do device enumerati... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/win/audio_manager_win.cc
===================================================================
--- media/audio/win/audio_manager_win.cc (revision 86276)
+++ media/audio/win/audio_manager_win.cc (working copy)
@@ -18,6 +18,7 @@
#include "base/process_util.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
+#include "base/stringprintf.h"
#include "base/win/windows_version.h"
#include "media/audio/fake_audio_input_stream.h"
#include "media/audio/fake_audio_output_stream.h"
@@ -253,6 +254,20 @@
base::LaunchApp(command_line, false, false, NULL);
}
+void AudioManagerWin::GetAudioInputDeviceNames(
+ AudioInputDeviceNames* device_names) {
+ // TODO(xians): query a full list of valid devices.
+ if (HasAudioInputDevices()) {
+ // We use (device_name)_(index) to make up the unique_ids to identify the
+ // devices. For default device, the index is 0, so its unique_id is
+ // Default_0.
+ AudioInputDeviceName name;
+ name.device_name = AudioManagerBase::kDefaultDeviceName;
awong 2011/05/23 17:36:15 ...This really seems odd now...
xians 2011/05/23 20:15:59 We only prepend the default device to the list to
+ name.unique_id = StringPrintf("%s_0", AudioManagerBase::kDefaultDeviceName);
+ device_names->push_back(name);
+ }
+}
+
// static
AudioManager* AudioManager::CreateAudioManager() {
return new AudioManagerWin();

Powered by Google App Engine
This is Rietveld 408576698