Register parameterized tests.

Register parameterized tests.

BUG=83563
R=phajdan.jr@chromium.org
TEST=browser_tests --gtest_filter=IPBTP/*.* // ensure that IPBTP/InProcessBrowserTestP.TestP/0 runs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86456

[Sheridan Rawlins, 2011-05-23 06:50:17]

Allow use of TEST_P and INSTANTIATE_TEST_CASE_P

[Paweł Hajdan Jr., 2011-05-23 19:11:24]

Thank you for catching the problem, just one comment about fixing it.

http://codereview.chromium.org/7060003/diff/1/chrome/test/out_of_proc_test_ru...
File chrome/test/out_of_proc_test_runner.cc (right):

http://codereview.chromium.org/7060003/diff/1/chrome/test/out_of_proc_test_ru...
chrome/test/out_of_proc_test_runner.cc:415:
unit_test->parameterized_test_registry().RegisterTests();
I don't think that's very maintainable. What if we need to call
some_other_test_registry().DoTheMagic() later so that something else works?

It seems testing::InitGoogleTest would do the right thing. Could you try it?

[Sheridan Rawlins, 2011-05-23 20:37:07]

Yep that works.

I also added IN_PROC_BROWSER_TEST_P in this CL, along with simplistic
parameterized browsertest.

http://codereview.chromium.org/7060003/diff/1/chrome/test/out_of_proc_test_ru...
File chrome/test/out_of_proc_test_runner.cc (right):

http://codereview.chromium.org/7060003/diff/1/chrome/test/out_of_proc_test_ru...
chrome/test/out_of_proc_test_runner.cc:415:
unit_test->parameterized_test_registry().RegisterTests();
On 2011/05/23 19:11:25, Paweł Hajdan Jr. wrote:
> I don't think that's very maintainable. What if we need to call
> some_other_test_registry().DoTheMagic() later so that something else works?
> 
> It seems testing::InitGoogleTest would do the right thing. Could you try it?

Done.

[Paweł Hajdan Jr., 2011-05-24 10:04:42]

LGTM with a nit. Thanks!

http://codereview.chromium.org/7060003/diff/6001/chrome/test/in_process_brows...
File chrome/test/in_process_browser_test_browsertest.cc (right):

http://codereview.chromium.org/7060003/diff/6001/chrome/test/in_process_brows...
chrome/test/in_process_browser_test_browsertest.cc:26: }
nit: // namespace

[commit-bot: I haz the power, 2011-05-24 15:04:26]

No LGTM from valid reviewers yet.

[Sheridan Rawlins, 2011-05-24 15:04:29]

http://codereview.chromium.org/7060003/diff/6001/chrome/test/in_process_brows...
File chrome/test/in_process_browser_test_browsertest.cc (right):

http://codereview.chromium.org/7060003/diff/6001/chrome/test/in_process_brows...
chrome/test/in_process_browser_test_browsertest.cc:26: }
On 2011/05/24 10:04:42, Paweł Hajdan Jr. wrote:
> nit: // namespace

Done.

[commit-bot: I haz the power, 2011-05-24 15:05:31]

No LGTM from valid reviewers yet.

[Sheridan Rawlins, 2011-05-24 15:37:45]

Pawel - you appear to be in the owners file - do I need another LGTM to run
commit-bot?  I can, of course, commit this by hand, but I'd like to understand
why the checkbox didn't just do the try and commit for me...

[Paweł Hajdan Jr., 2011-05-24 15:52:15]

I think it wants a rubber stamp for chrome/chrome_tests.gypi . My OWNERship is
only valid for chrome/test.