Issue 7060002: Mac: Fix WebGL in OS X 10.7 + misc. Sandbox cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7060002: Mac: Fix WebGL in OS X 10.7 + misc. Sandbox cleanup (Closed)

Created:
9 years, 7 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Nico, brettw

CC:
chromium-reviews, pam+watch_chromium.org, jam, Jói

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Fix WebGL in OS X 10.7 + misc. Sandbox cleanup * Allow IOKit access in 10.7. * Rename 10.6_ONLY to 10.6_OR_ABOVE and add a 10.7 version. * Fix path for common.sb in one place we missed the chrome->content move. BUG=75343 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86410

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -8 lines)			Patch
M	content/browser/gpu.sb	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	content/common/common.sb	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/sandbox_mac.mm	View	3 chunks	+12 lines, -4 lines	1 comment	Download
M	content/renderer/renderer.sb	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

LGTM http://codereview.chromium.org/7060002/diff/1/content/common/sandbox_mac.mm File content/common/sandbox_mac.mm (right): http://codereview.chromium.org/7060002/diff/1/content/common/sandbox_mac.mm#newcode537 content/common/sandbox_mac.mm:537: } |else [tokens_to_remove addObject:@";BEFORE_10.7"];| for symmetry?

9 years, 7 months ago (2011-05-22 16:01:06 UTC) #3

Change committed as 86410

Expand Messages | Collapse Messages