Issue 7059017: Fix paint flashing when switching tabs on ChromeOS. It seems like this hidden tab host window isn...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7059017: Fix paint flashing when switching tabs on ChromeOS. It seems like this hidden tab host window isn... (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix paint flashing when switching tabs on ChromeOS. It seems like this hidden tab host window isn't necessary... it was previously. Anyway, this fixes the flashing. BUG=chromium-os:15507 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86317

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -21 lines)			Patch
	M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc	View		2 chunks	+0 lines, -19 lines	0 comments	Download
	M	views/widget/native_widget_gtk.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Ben Goodger (Google)

It turns out I had to remove a DCHECK in NativeWidgetGtk as well. It turns ...

9 years, 7 months ago (2011-05-23 16:27:11 UTC) #3

SLGTM