Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/content_settings/content_settings_pattern_unittest.cc

Issue 7059016: Content settings pattern trim trailing dots from hostnames before matching a URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add one more test Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_settings/content_settings_pattern.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/content_settings_pattern_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_pattern_unittest.cc b/chrome/browser/content_settings/content_settings_pattern_unittest.cc
index 57078d277f7497bc5f415e459e03f90e1bc70105..11bef1e925a250f71b3c967d2a43178c3fa06371 100644
--- a/chrome/browser/content_settings/content_settings_pattern_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_pattern_unittest.cc
@@ -137,6 +137,20 @@ TEST(ContentSettingsPatternTest, Wildcard) {
ContentSettingsPattern::Wildcard()));
}
+TEST(ContentSettingsPatternTest, TrimEndingDotFromHost) {
+ EXPECT_TRUE(Pattern("www.example.com").IsValid());
+ EXPECT_TRUE(Pattern("www.example.com").Matches(
+ GURL("http://www.example.com")));
+ EXPECT_TRUE(Pattern("www.example.com").Matches(
+ GURL("http://www.example.com.")));
+
+ EXPECT_TRUE(Pattern("www.example.com.").IsValid());
+ EXPECT_STREQ("www.example.com",
+ Pattern("www.example.com.").ToString().c_str());
+
+ EXPECT_TRUE(Pattern("www.example.com.") == Pattern("www.example.com"));
+}
+
TEST(ContentSettingsPatternTest, FromString_WithNoWildcards) {
// HTTP patterns with default port.
EXPECT_TRUE(Pattern("http://www.example.com:80").IsValid());
« no previous file with comments | « chrome/browser/content_settings/content_settings_pattern.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698