Content settings pattern trim trailing dots from hostnames before matching a URL.

Content settings pattern trim trailing dots from hostnames before matching a URL.

BUG=83591
TEST=content_settings_pattern_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86424

[markusheintz_, 2011-05-23 15:13:08]

Please review this CL.
Thanks

[jochen (gone - plz use gerrit), 2011-05-23 15:56:15]

LGTM

[Bernhard Bauer, 2011-05-23 15:56:36]

Could you do that while canonicalizing the hostname, so you also get Compare() 
et al. right?

[markusheintz, 2011-05-23 16:48:45]

Am 23.05.2011 17:56 schrieb <bauerb@chromium.org>:
>
> Could you do that while canonicalizing the hostname, so you also get
Compare()
> et al. right?
>
I guess i'm missings someting, but Why should we allow hostnames with
trailing dots in pattern strings?

>
> http://codereview.chromium.org/7059016/

[Bernhard Bauer, 2011-05-23 16:55:08]

On Mon, May 23, 2011 at 09:48, Markus Heintz <markusheintz@google.com> wrote:
>
> Am 23.05.2011 17:56 schrieb <bauerb@chromium.org>:
>
>>
>> Could you do that while canonicalizing the hostname, so you also get
>> Compare()
>> et al. right?
>>
> I guess i'm missings someting, but Why should we allow hostnames with
> trailing dots in pattern strings?

Hm, you're right, I was confusing the host to be matched with the
pattern host. I guess we could just disallow them, but we could also
canonicalize them away when parsing the pattern (my thinking here
being that if it's a valid host when entered into the omnibox, it
should also be valid as a pattern).

>>
>> http://codereview.chromium.org/7059016/
>

[markusheintz_, 2011-05-23 19:34:18]

After thinking about this I strongly agree. It would allow us to take strings
form the omnibox and convert them to patterns.

[markusheintz_, 2011-05-23 19:38:16]

FYI: I will move the "Canonicalize" method from the ContentSettingsPattern class
to the Parser. But it's a different issue.

[Bernhard Bauer, 2011-05-24 14:30:25]

LGTM.