src/ia32/macro-assembler-ia32.cc - Issue 7059013: SMI checks for receiver in KeyedLoad/Store (done right this time)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 7059013: SMI checks for receiver in KeyedLoad/Store (done right this time) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: correct test options Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index b6e1d000b35bd0dac25b72a49813a99c7c83ed20..047236f43d8f3bd324b80c70e4f01584ed26d574 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -296,7 +296,7 @@ void MacroAssembler::DispatchMap(Register obj,

Handle<Code> success,

SmiCheckType smi_check_type) {

Label fail;

- if (smi_check_type == DONT_DO_SMI_CHECK) {

+ if (smi_check_type == DO_SMI_CHECK) {

JumpIfSmi(obj, &fail);

}

cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map));

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »