Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 7059013: SMI checks for receiver in KeyedLoad/Store (done right this time) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: correct test options Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map)); 289 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map));
290 j(not_equal, fail); 290 j(not_equal, fail);
291 } 291 }
292 292
293 293
294 void MacroAssembler::DispatchMap(Register obj, 294 void MacroAssembler::DispatchMap(Register obj,
295 Handle<Map> map, 295 Handle<Map> map,
296 Handle<Code> success, 296 Handle<Code> success,
297 SmiCheckType smi_check_type) { 297 SmiCheckType smi_check_type) {
298 Label fail; 298 Label fail;
299 if (smi_check_type == DONT_DO_SMI_CHECK) { 299 if (smi_check_type == DO_SMI_CHECK) {
300 JumpIfSmi(obj, &fail); 300 JumpIfSmi(obj, &fail);
301 } 301 }
302 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map)); 302 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map));
303 j(equal, success); 303 j(equal, success);
304 304
305 bind(&fail); 305 bind(&fail);
306 } 306 }
307 307
308 308
309 Condition MacroAssembler::IsObjectStringType(Register heap_object, 309 Condition MacroAssembler::IsObjectStringType(Register heap_object,
(...skipping 1778 matching lines...) Expand 10 before | Expand all | Expand 10 after
2088 2088
2089 // Check that the code was patched as expected. 2089 // Check that the code was patched as expected.
2090 ASSERT(masm_.pc_ == address_ + size_); 2090 ASSERT(masm_.pc_ == address_ + size_);
2091 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 2091 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
2092 } 2092 }
2093 2093
2094 2094
2095 } } // namespace v8::internal 2095 } } // namespace v8::internal
2096 2096
2097 #endif // V8_TARGET_ARCH_IA32 2097 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698