Issue 7059001: WebUI: make cookies and site data column headers consistent with other table headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7059001: WebUI: make cookies and site data column headers consistent with other table headers. (Closed)

Created:
9 years, 7 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

WebUI: make cookies and site data column headers consistent with other table headers. This also makes the text a little smaller, possibly helping to address issue 78059. BUG=78059 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86229

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/cookies_view.css	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/resources/options/cookies_view.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM http://codereview.chromium.org/7059001/diff/1/chrome/browser/resources/options/cookies_view.js File chrome/browser/resources/options/cookies_view.js (right): http://codereview.chromium.org/7059001/diff/1/chrome/browser/resources/options/cookies_view.js#newcode46 chrome/browser/resources/options/cookies_view.js:46: * Search cookie using text in cookies-search-box. nit: ...

9 years, 7 months ago (2011-05-22 00:05:47 UTC) #2

Mike Mammarella

9 years, 7 months ago (2011-05-22 00:12:07 UTC) #3

http://codereview.chromium.org/7059001/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/cookies_view.js (right):

http://codereview.chromium.org/7059001/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/cookies_view.js:46: * Search cookie using text
in cookies-search-box.
On 2011/05/22 00:05:47, James Hawkins wrote:
> nit: |cookies-search-box|.

Done.

Expand Messages | Collapse Messages