create one video capture message filter per renderer process

create one video capture message filter per renderer process
BUG=none
TEST=try bots
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88396

[jam, 2011-06-08 18:27:35]

lgtm

[scherkus (not reviewing), 2011-06-08 18:46:23]

drive by

thanks for doing this!!

http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
File content/renderer/media/video_capture_impl_unittest.cc (right):

http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
content/renderer/media/video_capture_impl_unittest.cc:60: :VideoCaptureImpl(id,
ml_proxy, filter) {
nit: space after :

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
File content/renderer/video_capture_message_filter_creator.cc (right):

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
content/renderer/video_capture_message_filter_creator.cc:10: filter_ = new
VideoCaptureMessageFilter(1);
sanity checking: what does 1 as a route_id imply?

[wjia(left Chromium), 2011-06-08 20:51:53]

http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
File content/renderer/media/video_capture_impl_unittest.cc (right):

http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
content/renderer/media/video_capture_impl_unittest.cc:60: :VideoCaptureImpl(id,
ml_proxy, filter) {
On 2011/06/08 18:46:23, scherkus wrote:
> nit: space after :

Done.

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
File content/renderer/video_capture_message_filter_creator.cc (right):

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
content/renderer/video_capture_message_filter_creator.cc:10: filter_ = new
VideoCaptureMessageFilter(1);
On 2011/06/08 18:46:23, scherkus wrote:
> sanity checking: what does 1 as a route_id imply?

The route_id is not really needed here. The video capture messages will be
changed to "control" message in the next patch.

[scherkus (not reviewing), 2011-06-08 20:56:53]

Cool!

Lgtm
On Jun 8, 2011 1:51 PM, <wjia@chromium.org> wrote:
> Reviewers: John Abd-El-Malek, scherkus,
>
>
>
http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
> File content/renderer/media/video_capture_impl_unittest.cc (right):
>
>
http://codereview.chromium.org/7058055/diff/14001/content/renderer/media/vide...
> content/renderer/media/video_capture_impl_unittest.cc:60:
> :VideoCaptureImpl(id, ml_proxy, filter) {
> On 2011/06/08 18:46:23, scherkus wrote:
>> nit: space after :
>
> Done.
>
>
http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
> File content/renderer/video_capture_message_filter_creator.cc (right):
>
>
http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
> content/renderer/video_capture_message_filter_creator.cc:10: filter_ =
> new VideoCaptureMessageFilter(1);
> On 2011/06/08 18:46:23, scherkus wrote:
>> sanity checking: what does 1 as a route_id imply?
>
> The route_id is not really needed here. The video capture messages will
> be changed to "control" message in the next patch.
>
> Description:
> create one video capture message filter per renderer process
> BUG=none
> TEST=try bots
>
> Please review this at http://codereview.chromium.org/7058055/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> M content/content_renderer.gypi
> M content/renderer/media/video_capture_impl.h
> M content/renderer/media/video_capture_impl.cc
> M content/renderer/media/video_capture_impl_manager.cc
> M content/renderer/media/video_capture_impl_unittest.cc
> M content/renderer/render_thread.cc
> M content/renderer/video_capture_message_filter.h
> M content/renderer/video_capture_message_filter.cc
> A content/renderer/video_capture_message_filter_creator.h
> A content/renderer/video_capture_message_filter_creator.cc
>
>

[jam, 2011-06-21 19:43:08]

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
File content/renderer/video_capture_message_filter_creator.cc (right):

http://codereview.chromium.org/7058055/diff/14001/content/renderer/video_capt...
content/renderer/video_capture_message_filter_creator.cc:10: filter_ = new
VideoCaptureMessageFilter(1);
On 2011/06/08 20:51:53, wjia wrote:
> On 2011/06/08 18:46:23, scherkus wrote:
> > sanity checking: what does 1 as a route_id imply?
> 
> The route_id is not really needed here. The video capture messages will be
> changed to "control" message in the next patch.


Hi, this hasn't been done yet as we discussed.  Please do so as soon as
possible, i.e. before any other changes to this code.  This code can and is used
by others for inspiration, so we need to have it used IPC correctly. Thanks.