Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: rietveld.py

Issue 7058054: Add --rietveld_XXX arguments to presubmit_support to the commit queue can use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 40be3c0eefcaf6d6516e72cc8e3304dd21e0fe6f..56e0a441912b038faefacf1fc1caf14f1eb6ddef 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -42,6 +42,12 @@ class Rietveld(object):
"""Accesses rietveld."""
def __init__(self, url, email, password, extra_headers=None):
self.url = url
+ # TODO(maruel): It's not awesome but maybe necessary to retrieve the value.
+ # It happens when the presubmit check is ran out of process, the cookie
+ # needed to be recreated from the credentials. Instead, it should pass the
+ # email and the cookie.
+ self.email = email
+ self.password = password
if email and password:
get_creds = lambda: (email, password)
self.rpc_server = upload.HttpRpcServer(
« no previous file with comments | « presubmit_support.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698