Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 7058054: Add --rietveld_XXX arguments to presubmit_support to the commit queue can use it. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add --rietveld_XXX arguments to presubmit_support to the commit queue can use it. presubmit_support.py can now creates a Rietveld object on its own. This is necessary since the object needs to be recreated out of process. The commit queue runs the presubmit check out of process for sanity reasons. Added TODO to push the cookie instead of the password. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M presubmit_support.py View 10 chunks +21 lines, -11 lines 0 comments Download
M rietveld.py View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-03 19:55:31 UTC) #1
Dirk Pranke
9 years, 6 months ago (2011-06-03 20:01:52 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698