Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2456)

Unified Diff: chrome/browser/resources/keyboard/main.js

Issue 7058046: Adjust virtual keyboard size base on input method candidates. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/keyboard/main.js
diff --git a/chrome/browser/resources/keyboard/main.js b/chrome/browser/resources/keyboard/main.js
index cf3f97a93505f5f8e95c1037f793d0255ff41f03..b440935f313e8517502df8faa6eb5a8c33b1a00a 100644
--- a/chrome/browser/resources/keyboard/main.js
+++ b/chrome/browser/resources/keyboard/main.js
@@ -578,7 +578,7 @@ var allRows = []; // Populated during start()
*/
function getRowHeight() {
var x = window.innerWidth;
- var y = window.innerHeight - (imeui ? IME_HEIGHT - 2 : 0);
+ var y = window.innerHeight - ((imeui && imeui.visible) ? IME_HEIGHT : 0);
return (x > kKeyboardAspect * y) ?
(height = Math.floor(y / 4)) :
(height = Math.floor(x / (kKeyboardAspect * 4)));
@@ -647,6 +647,8 @@ function sendKeyFunction(key) {
}
}
+var oldHeight = 0;
+var oldX = 0;
/**
* Resize the keyboard according to the new window size.
* @return {void}
@@ -655,16 +657,23 @@ window.onresize = function() {
var height = getRowHeight();
var newX = document.documentElement.clientWidth;
- // All rows should have the same aspect, so just use the first one
- var totalWidth = Math.floor(height * allRows[0].aspect);
- var leftPadding = Math.floor((newX - totalWidth) / 2);
- document.getElementById('b').style.paddingLeft = leftPadding + 'px';
+ if (newX != oldX || height != oldHeight) {
bryeung 2011/06/07 22:45:03 Sorry: I'm still not understanding. Are you sayin
Peng 2011/06/08 14:59:57 Yeah. Sometime, the window.onresize is caused by s
+ // All rows should have the same aspect, so just use the first one
+ var totalWidth = Math.floor(height * allRows[0].aspect);
+ var leftPadding = Math.floor((newX - totalWidth) / 2);
+ document.getElementById('b').style.paddingLeft = leftPadding + 'px';
+ }
- for (var i = 0; i < allRows.length; ++i) {
- allRows[i].resize(height);
+ if (height != oldHeight) {
+ for (var i = 0; i < allRows.length; ++i) {
+ allRows[i].resize(height);
+ }
}
updateIme();
+
+ oldHeight = height;
+ oldX = newX;
}
/**
@@ -680,10 +689,12 @@ window.onload = function() {
allRows.push(new Row(i, KEYS[i]));
}
+ height = getRowHeight();
for (var i = 0; i < allRows.length; ++i) {
- body.appendChild(allRows[i].makeDOM(getRowHeight()));
+ body.appendChild(allRows[i].makeDOM(height));
allRows[i].showMode(KEY_MODE);
}
+ oldHeight = height;
window.onresize();
}

Powered by Google App Engine
This is Rietveld 408576698